Skip to content

Add support for ALTER TABLE DROP INDEX #1865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2025

Conversation

vimko
Copy link
Contributor

@vimko vimko commented May 28, 2025

This PR adds support for mysql's drop index:

  • DROP INDEX idx_a ON table_a
  • ALTER TABLE table_a DROP INDEX idx_a

Addresses #1863

@iffyio
Copy link
Contributor

iffyio commented May 29, 2025

Thanks @vimko! fyi there's a similar PR here for DROP INDEX idx_a on table_a feature, we'll probably look to land that one and rebase this on top of it

@vimko
Copy link
Contributor Author

vimko commented May 29, 2025

@iffyio Indeed, I didn't notice that. Thank you very much for reminding me.

@vimko vimko changed the title Add support for mysql's drop index (DROP INDEX idx_a ON table_a and ALTER TABLE table_a DROP INDEX idx_a) Add support for mysql's drop index (ALTER TABLE table_a DROP INDEX idx_a) Jun 4, 2025
@iffyio iffyio changed the title Add support for mysql's drop index (ALTER TABLE table_a DROP INDEX idx_a) Add support for ALTER TABLE DROP INDEX Jun 10, 2025
@iffyio
Copy link
Contributor

iffyio commented Jun 10, 2025

@vimko could you take a look at the cargo failure when you get the chance?

@vimko vimko force-pushed the fix-mysql-drop-index-error branch from 502ea78 to 3676f6e Compare June 10, 2025 12:39
@vimko
Copy link
Contributor Author

vimko commented Jun 10, 2025

@vimko could you take a look at the cargo failure when you get the chance?

@iffyio Thank you for the reminder, I have already taken care of it.

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again @vimko!
cc @alamb

@iffyio iffyio merged commit 559b7e3 into apache:main Jun 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants