Re-Enable num_centroids to approx_percentile_cont
#798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsaucer
reviewed
Aug 6, 2024
timsaucer
approved these changes
Aug 6, 2024
|
@andygrove this is ready to go, and then the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #777.
Supersedes #794 #785 #739 #732.
Rationale for this change
When
approx_percentile_contwas migrated to a UDAf upstream, thenum_centroidsargument was removed from its fluent API.This works around that by invoking the
AggregateFunction::calldirectly.What changes are included in this PR?
Though
approx_percentile_contis re-enabled, this actually matches the behavior of the last release.Are there any user-facing changes?
No.