Skip to content

fix: fallback to Spark scan if encryption is enabled (native_datafusion/native_iceberg_compat) #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025

Conversation

parthchandra
Copy link
Contributor

Which issue does this PR close?

Part of #1542
Closes #.

Rationale for this change

Encrypted files are not currently supported and cause failure

What changes are included in this PR?

If encryption is enabled, fallback to Spark.

How are these changes tested?

Existing Spark SQL ParquetEncryptionSuite

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 59.55%. Comparing base (f09f8af) to head (ad38777).
Report is 222 commits behind head on main.

Files with missing lines Patch % Lines
...n/scala/org/apache/comet/rules/CometScanRule.scala 0.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1785      +/-   ##
============================================
+ Coverage     56.12%   59.55%   +3.42%     
- Complexity      976     1144     +168     
============================================
  Files           119      129      +10     
  Lines         11743    12596     +853     
  Branches       2251     2360     +109     
============================================
+ Hits           6591     7501     +910     
+ Misses         4012     3899     -113     
- Partials       1140     1196      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@parthchandra parthchandra force-pushed the complex-sql-tests-4 branch from 9b69d55 to 7740250 Compare May 27, 2025 23:38
@parthchandra
Copy link
Contributor Author

Also added a small fix for field id types in native_iceberg_compat

@parthchandra parthchandra force-pushed the complex-sql-tests-4 branch from 7740250 to a3ac6e4 Compare May 28, 2025 13:53
@parthchandra
Copy link
Contributor Author

reverted change for field_ids

@parthchandra parthchandra force-pushed the complex-sql-tests-4 branch from ec0347f to ad38777 Compare May 28, 2025 20:09
@parthchandra parthchandra requested a review from andygrove May 28, 2025 22:31
@parthchandra
Copy link
Contributor Author

@andygrove @mbutrovich

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @parthchandra

@parthchandra parthchandra merged commit ced7392 into apache:main May 28, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants