-
Notifications
You must be signed in to change notification settings - Fork 206
[WIP] Remove COMET_SHUFFLE_FALLBACK_TO_COLUMNAR
config
#1736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
andygrove
wants to merge
8
commits into
apache:main
Choose a base branch
from
andygrove:remove-shuffle-fallback-hack
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1736 +/- ##
============================================
+ Coverage 56.12% 59.42% +3.29%
- Complexity 976 1151 +175
============================================
Files 119 130 +11
Lines 11743 12652 +909
Branches 2251 2370 +119
============================================
+ Hits 6591 7518 +927
+ Misses 4012 3928 -84
- Partials 1140 1206 +66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There are now many more test failures than when this PR was first created. |
Working on this |
1 similar comment
Working on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1254
Rationale for this change
The config
COMET_SHUFFLE_FALLBACK_TO_COLUMNAR
was added as a workaround for Spark SQL test failures and we need to remove it since users could run into the same bugs that is causing the Spark SQL failures.What changes are included in this PR?
How are these changes tested?