fix: respect ignoreNulls flag in first_value and last_value
#1626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1626 +/- ##
============================================
+ Coverage 56.12% 58.74% +2.62%
- Complexity 976 1081 +105
============================================
Files 119 125 +6
Lines 11743 12584 +841
Branches 2251 2361 +110
============================================
+ Hits 6591 7393 +802
- Misses 4012 4018 +6
- Partials 1140 1173 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@anuragmantri fyi, I already had this PR open from a while back. It does not resolve the issue but seems worth merging while we work on figuring out a test approach. |
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1630
Rationale for this change
We know it is wrong to ignore the
ignoreNullsflag, but we do not have tests for this yet. This PR stops ignoring the flag and does not cause any regressions, so we may as well merge it IMO and then follow up to add tests so that we can close the issue.We need to figure out what to do about testing these non-deterministic functions in #1646 before we can add tests for
ignoreNulls.What changes are included in this PR?
How are these changes tested?