Skip to content

CASSGO-76: Add Makefile #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2025
Merged

CASSGO-76: Add Makefile #1881

merged 2 commits into from
May 30, 2025
+217 −180

Conversation

dkropachev
Copy link
Contributor

@dkropachev dkropachev commented Apr 16, 2025 •
edited
Loading

Implement all CICD steps in Makefile and make workflows use Makefile.
It will help with local development and reproducing CICD issues locally.

Ticket: https://issues.apache.org/jira/browse/CASSGO-76

@dkropachev
Copy link
Contributor Author

@tengu-alt, can you please review it

@dkropachev dkropachev force-pushed the dk/add-makefile branch 2 times, most recently from de28466 to 15d2ae0 Compare April 16, 2025 17:21
@joao-r-reis
Copy link
Contributor

joao-r-reis commented Apr 16, 2025 •
edited
Loading

This seems like a reasonable proposal but I'd like to see some kind of discussion in a C* dev mailing list thread or ASF #cassandra-drivers slack channel to see if there is broad community support for this

@dkropachev
Copy link
Contributor Author

This seems like a reasonable proposal but I'd like to see some kind of discussion in a C* dev mailing list thread or ASF #cassandra-drivers slack channel to see if there is broad community support for this

Can you invite me to the workspace and channel, you can find my email on the account.

@dkropachev
Copy link
Contributor Author

@joao-r-reis , can you please invite me to the slack, so that I could start discussion there ?

@joao-r-reis
Copy link
Contributor

There's a link on the repo's README file

@dkropachev
Copy link
Contributor Author

There's a link on the repo's README file

@joao-r-reis , that link is not working:

This invite has expired
We let the person who sent this invite know that you tried to join, so you may hear from them again soon.

@joao-r-reis
Copy link
Contributor

I'm getting an error saying that a user with that email address is already on the slack workspace, you should be able to log in with that email address I think?

@dkropachev
Copy link
Contributor Author

I'm getting an error saying that a user with that email address is already on the slack workspace, you should be able to log in with that email address I think?

Thanks someone already invited me

jameshartig
jameshartig reviewed May 4, 2025
View reviewed changes
@dkropachev dkropachev force-pushed the dk/add-makefile branch 2 times, most recently from 4e77397 to 172d2f4 Compare May 6, 2025 09:18
@dkropachev dkropachev force-pushed the dk/add-makefile branch 5 times, most recently from 81ddbd4 to 0ff9bcb Compare May 28, 2025 17:15
dkropachev added 2 commits May 28, 2025 13:17
@dkropachev
Move all cicd steps into Makefile
ba3b63e 
1. Implement all steps in Makefile
2. Make CICD use Makefile
3. Drop setup-environment step, it is done automatically now
4. Add linting step
@dkropachev
conn_test: address linter complaints
8452aaa
@dkropachev dkropachev changed the title Add Makefile CASSGO-76: Add Makefile May 29, 2025
@joao-r-reis joao-r-reis merged commit 7279756 into apache:trunk May 30, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joao-r-reis joao-r-reis joao-r-reis approved these changes

@jameshartig jameshartig Awaiting requested review from jameshartig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkropachev @joao-r-reis @jameshartig