CASSGO-55 - User API doc enhancement #1863
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengu-alt
changed the title
tengu-alt
force-pushed
the
update-public-methods-doc
branch
from
4c82386 to
2ec07af
Compare
tengu-alt
changed the title
tengu-alt
force-pushed
the
update-public-methods-doc
branch
from
2ec07af to
171d258
Compare
tengu-alt
force-pushed
the
update-public-methods-doc
branch
from
171d258 to
044b4f5
Compare
joao-r-reis
reviewed
Mar 25, 2025
filters.go
Outdated
| @@ -61,12 +62,6 @@ func DataCenterHostFilter(dataCenter string) HostFilter { | |||
| }) | |||
| } | |||
|
|
|||
| // Deprecated: Use DataCenterHostFilter instead. | |||
| // DataCentreHostFilter is an alias that doesn't use the preferred spelling. | |||
| func DataCentreHostFilter(dataCenter string) HostFilter { | |||
There was a problem hiding this comment.
This was deprecated very recently for the 2.0 release, we don't want to remove it now.
There was a problem hiding this comment.
Got it, I have returned it.
joao-r-reis
reviewed
Mar 25, 2025
There was a problem hiding this comment.
Added 1 comment. #1868 will change the query and batch API so I'd like to get that merged before merging this one.
tengu-alt
force-pushed
the
update-public-methods-doc
branch
from
044b4f5 to
63b6d78
Compare
|
Sorry for that, I've accidentally pushed without changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the user-exposed API is not documented which can cause misuse. This PR provides doc update fo the public methods and interfaces. Also, some deprecated features were removed.
Fix for the #1601