GH-49566: [Python] Skip header files when installing compiled Cython files#49571
GH-49566: [Python] Skip header files when installing compiled Cython files#49571AlenkaF wants to merge 2 commits intoapache:mainfrom
Conversation
|
|
|
@github-actions crossbow submit verify-rc-source-python-* |
|
Revision: 719eaf2 Submitted crossbow builds: ursacomputing/crossbow @ actions-3593c891fd
|
|
macOS failure are unrelated, I am trying to find a fix, the issue tracking them is this one: |
|
We have a different issue now: _____________________________ test_pyarrow_include _____________________________
def test_pyarrow_include():
# We need to make sure that pyarrow/include is always
# created. Either with PyArrow C++ header files or with
# Arrow C++ and PyArrow C++ header files together
source = os.path.dirname(os.path.abspath(__file__))
pyarrow_dir = pjoin(source, '..')
pyarrow_include = pjoin(pyarrow_dir, 'include')
pyarrow_cpp_include = pjoin(pyarrow_include, 'arrow', 'python')
> assert os.path.exists(pyarrow_include)
E AssertionError: assert False
E + where False = <function exists at 0x7ff433ef9e80>('/arrow/python/pyarrow/tests/../include')
E + where <function exists at 0x7ff433ef9e80> = <module 'posixpath' (frozen)>.exists
E + where <module 'posixpath' (frozen)> = os.pathInvestigating ... |
|
@github-actions crossbow submit verify-rc-source-python-* |
|
Revision: 9ba4a76 Submitted crossbow builds: ursacomputing/crossbow @ actions-7e817c381a
|
|
Another issue I need to investigate: |
|
@github-actions crossbow submit verify-rc-source-python-macos-arm64 |
|
Testing if it is a flaky macos issue ... |
|
Revision: 9ba4a76 Submitted crossbow builds: ursacomputing/crossbow @ actions-49b32e9b3a
|
|
@github-actions crossbow submit verify-rc-source-python-macos-amd64 |
|
Revision: 9ba4a76 Submitted crossbow builds: ursacomputing/crossbow @ actions-109f022a4d
|
2 participants
Rationale for this change
Local import is broken when doing editable install with scikit-build-core, also nightly verification jobs are failing for the same reason.
What changes are included in this PR?
lib.handlib_api.hare already installed separately so we skip them when installing Cython extensions into the output destination (side-packages/pyarrow).Are these changes tested?
Yes, locally and via the extended verification builds.
Are there any user-facing changes?
No.