GH-49103: [Python] Add internal type system stubs (_types, error, _stubs_typing)#48622
Open
rok wants to merge 13 commits intoapache:mainfrom
Open
GH-49103: [Python] Add internal type system stubs (_types, error, _stubs_typing)#48622rok wants to merge 13 commits intoapache:mainfrom
rok wants to merge 13 commits intoapache:mainfrom
Conversation
d3c5740 to
27d1c65
Compare
Member
Author
|
I've rebased this on the annotation infra check PR (#48618) to make sure we're on the right track. |
3f9ed3b to
0ac95b0
Compare
|
|
7873930 to
43e7cc6
Compare
51a7a4e to
7bc0a98
Compare
0d15871 to
8f3796d
Compare
8f3796d to
72571d2
Compare
bea93c6 to
85f625c
Compare
10 tasks
diff --git c/python/CMakeLists.txt i/python/CMakeLists.txt index 6395b3e..f71a495 100644 --- c/python/CMakeLists.txt +++ i/python/CMakeLists.txt @@ -1042,9 +1042,9 @@ if(EXISTS "${PYARROW_STUBS_SOURCE_DIR}") install(CODE " execute_process( COMMAND \"${Python3_EXECUTABLE}\" - \"${CMAKE_CURRENT_SOURCE_DIR}/scripts/update_stub_docstrings.py\" + \"${CMAKE_SOURCE_DIR}/scripts/update_stub_docstrings.py\" \"${CMAKE_INSTALL_PREFIX}\" - \"${CMAKE_CURRENT_SOURCE_DIR}\" + \"${CMAKE_SOURCE_DIR}\" RESULT_VARIABLE _pyarrow_stub_docstrings_result ) if(NOT _pyarrow_stub_docstrings_result EQUAL 0)
Co-authored-by: Dan Redding <125183946+dangotbanned@users.noreply.github.com>
Co-authored-by: Dan Redding <125183946+dangotbanned@users.noreply.github.com>
85f625c to
2cddfd2
Compare
Member
Author
|
@dangotbanned I'm about to have limited connectivity for 2 weeks. If you think this is ready we can ask @raulcd to do a last pass and merge, so we get it into the release. @raulcd I found that I had to do this df7dce5 to get a working editable install. Seems to be due to filename collisions. Thoughts? |
2cddfd2 to
104369a
Compare
Member
Member
Author
|
The error I was getting without the CMake change was: >>> import pyarrow
Traceback (most recent call last):
File "<python-input-0>", line 1, in <module>
import pyarrow
File "/Users/rok/Documents/repos/arrow/python/pyarrow/__init__.py", line 59, in <module>
from pyarrow.lib import (BuildInfo, CppBuildInfo, RuntimeInfo, set_timezone_db_path,
...<3 lines>...
io_thread_count, is_opentelemetry_enabled, set_io_thread_count)
ModuleNotFoundError: No module named 'pyarrow.lib'With the CMake change it works fine. In both cases I'm doing: export ARROW_HOME=$(pwd)/dist
export CMAKE_PREFIX_PATH=$ARROW_HOME:$CMAKE_PREFIX_PATH
export DYLD_LIBRARY_PATH=$ARROW_HOME/lib:$DYLD_LIBRARY_PATH
uv pip install --no-build-isolation --editable . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This is the second in series of PRs adding type annotations to pyarrow and resolving #32609. It builds on top of and should be merged after #48618.
What changes are included in this PR?
This adds:
_types.pyi- Core type definitions including_stubs_typing.pyi- Internal typing protocols and helpers used across stub fileserror.pyi- Exception classes (ArrowException,ArrowInvalid,ArrowIOError, etc.)lib.pyi,io.pyi,scalar.pyi- using__getattr__to allow imports to resolve while deferring to subsequent PRsAre these changes tested?
Via CI type checks established in #48618.
Are there any user-facing changes?
Users will start seeing some minimal annotated types.