GH-40348: [Python] Add Python wrapper for VariableShapeTensor#40354
Open
rok wants to merge 1 commit intoapache:mainfrom
Open
GH-40348: [Python] Add Python wrapper for VariableShapeTensor#40354rok wants to merge 1 commit intoapache:mainfrom
rok wants to merge 1 commit intoapache:mainfrom
Conversation
github-actions
bot
added
Component: C++
Component: Python
Component: Documentation
labels
AlenkaF
reviewed
Mar 12, 2024
Member
AlenkaF
left a comment
AlenkaF
left a comment
There was a problem hiding this comment.
Small nits =) Thank you for working on this, takes lots of work!
rok
force-pushed
the
38007_python
branch
8 times, most recently
from
b6b63a6 to
a372fe6
Compare
github-actions
bot
added
awaiting changes
Member
|
The failures are connected. |
github-actions
bot
added
awaiting change review
rok
force-pushed
the
38007_python
branch
4 times, most recently
from
fab047e to
f58c973
Compare
rok
force-pushed
the
38007_python
branch
2 times, most recently
from
5197532 to
55cc40b
Compare
github-actions
bot
added
the
Status: stale-warning
rok
force-pushed
the
38007_python
branch
2 times, most recently
from
9b0f2b6 to
7f84762
Compare
rok
force-pushed
the
38007_python
branch
2 times, most recently
from
4429dd2 to
b4cb6cd
Compare
rok
commented
Feb 27, 2026
Comment on lines
+265
to
268
| internal::Permute<int64_t>(permutation, &shape); | ||
| ARROW_ASSIGN_OR_RAISE( | ||
| auto strides, internal::ComputeStrides(ext_type.value_type(), shape, permutation)); | ||
| internal::Permute<int64_t>(permutation, &shape); | ||
|
|
Member
Author
There was a problem hiding this comment.
I'm thinking thinking about this still. It's probably a bug or a different interpretation at least.
github-actions
bot
added
awaiting changes
rok
force-pushed
the
38007_python
branch
3 times, most recently
from
0df8139 to
d5a548d
Compare
Add PyArrow bindings for the VariableShapeTensor extension type, including VariableShapeTensorType, VariableShapeTensorArray, and VariableShapeTensorScalar with support for converting to/from NumPy tensors.
Member
Author
|
@AlenkaF could you do a quick pass on this? I'm a little unsure about the |
Member
|
@rok sure! Will have a look later today. |
Member
|
I did a very quick look at the code now. I would suggest splitting this PR into two as there is quite a lot of lines added and there might be even something that can be moved out. Moving the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Once C++ implementation of VariableShapeTensor is complete (#38007) we want a Python wrapper for
VariableShapeTensor.What changes are included in this PR?
This adds a Python wrapper for
VariableShapeTensor.Are these changes tested?
This adds appropriate Python tests.
Are there any user-facing changes?
Yes, a new extension and array type are exposed.