-
Notifications
You must be signed in to change notification settings - Fork 2.8k
ci: fix flaky tests #12836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shreemaan-abhishek
wants to merge
6
commits into
apache:master
Choose a base branch
from
shreemaan-abhishek:ci/fix-flaky-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ci: fix flaky tests #12836
shreemaan-abhishek
wants to merge
6
commits into
apache:master
from
shreemaan-abhishek:ci/fix-flaky-tests
+30
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Choudhary <[email protected]>
Signed-off-by: Abhishek Choudhary <[email protected]>
nic-6443
reviewed
Dec 24, 2025
nic-6443
reviewed
Dec 24, 2025
Signed-off-by: Abhishek Choudhary <[email protected]>
nic-6443
previously approved these changes
Dec 24, 2025
membphis
previously approved these changes
Dec 24, 2025
Signed-off-by: Abhishek Choudhary <[email protected]>
7059d15
Signed-off-by: Abhishek Choudhary <[email protected]>
Signed-off-by: Abhishek Choudhary <[email protected]>
50884c6 to
b8808a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The sls logger failure got fixed by just waiting for a while to let the workers receive update from etcd.
Whereas, no clear fix was found for lago tests failures as most failures were due to
client socket timed out.So we modify the
--- execdirective of APISIX.pm to timeout one second before the exec request times out there by appropriately reporting the stdout and stderr of the exec request instead of an empty''message.This will help us understand the underlying reason of lago test failure and fix it in future.
Here is the verification that the test will output stdout/stderr properly when client socket times out:
Checklist