Skip to content

Conversation

@shreemaan-abhishek
Copy link
Contributor

@shreemaan-abhishek shreemaan-abhishek commented Dec 23, 2025

Description

The sls logger failure got fixed by just waiting for a while to let the workers receive update from etcd.

Whereas, no clear fix was found for lago tests failures as most failures were due to client socket timed out.
So we modify the --- exec directive of APISIX.pm to timeout one second before the exec request times out there by appropriately reporting the stdout and stderr of the exec request instead of an empty '' message.

This will help us understand the underlying reason of lago test failure and fix it in future.

Here is the verification that the test will output stdout/stderr properly when client socket times out:

image

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Signed-off-by: Abhishek Choudhary <[email protected]>
Signed-off-by: Abhishek Choudhary <[email protected]>
f
Signed-off-by: Abhishek Choudhary <[email protected]>
@shreemaan-abhishek shreemaan-abhishek marked this pull request as ready for review December 24, 2025 04:02
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. CI labels Dec 24, 2025
nic-6443
nic-6443 previously approved these changes Dec 24, 2025
membphis
membphis previously approved these changes Dec 24, 2025
Signed-off-by: Abhishek Choudhary <[email protected]>
@shreemaan-abhishek shreemaan-abhishek dismissed stale reviews from membphis and nic-6443 via 7059d15 December 24, 2025 11:03
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 24, 2025
Signed-off-by: Abhishek Choudhary <[email protected]>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Dec 26, 2025
Signed-off-by: Abhishek Choudhary <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants