Skip to content

Conversation

@Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Apr 16, 2025

Follow up: https://github.com/apache/apisix/pull/12126/files
Fixes # The case when nodes are nil still doesn't release healthchecker. This PR fixes that.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Apr 16, 2025
@Baoyuantop
Copy link
Contributor

Hi @Revolyssup, is this PR still being processed?

@Revolyssup
Copy link
Contributor Author

@Baoyuantop I am waiting for review from my side.

@Revolyssup Revolyssup requested review from nic-6443 and nic-chen May 6, 2025 16:39
@github-actions
Copy link

github-actions bot commented Jul 6, 2025

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 6, 2025
@Baoyuantop Baoyuantop removed the stale label Jul 7, 2025
@github-actions
Copy link

github-actions bot commented Sep 5, 2025

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 5, 2025
@Baoyuantop
Copy link
Contributor

Hi @Revolyssup, do we still need this PR?

@github-actions github-actions bot removed the stale label Sep 8, 2025
@nic-6443
Copy link
Member

@Baoyuantop we can close it now, we've completely refactored the health checker module.

@Baoyuantop Baoyuantop closed this Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants