-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add workers.celery.securityContexts & workers.kubernetes.securityContexts #60396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add workers.celery.securityContexts & workers.kubernetes.securityContexts #60396
Conversation
|
Adding a little more context to additional changes:
+ I believe that this PR might be easier to review commit by commit |
|
This time you did not mark the (non celery/k8s) workers parameters as deprecated - is this by intend? Because now both can be specified? Also no newsfragment about this? |
|
Yes. The idea is, if some Regarding the where |
Okay, this makes sense. Then also no parameter deprecated, also no newsfragment needed. That is fine. But can you please add a note to the new/old parameters describing the behavior of "one or the other" and the order of selection to both parameters please? Otherwise users will be confused (like me :-D) |
|
Ahhh, I forgot to add it, sorry. I will add it in a couple of minutes Also, maybe at this time the network error in tests will resolve itself :D |
f469f53 to
3c56fda
Compare
|
Clarifying comments added - let me know if it's good now |
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments, looks good!
|
Small nit - I added the |
|
FYI: The S3 error is unrelated to your changes. I opened an issue to track this fix. Hopefully, that solves it. |
|
Now a merge conflict from the other PR :-( |
related: #28880
This PR introduces two new fields:
workers.celery.securityContextsandworkers.kubernetes.securityContexts. Theworkers.securityContextsfield is not deprecated, as it is used by two worker types. Now it will be possible to use dedicated commands for both Celery and Kubernetes workers.Despite adding new sections, the following things were done:
security/test_security_context.pysecurity/test_security_context.pyandairflow_aux/test_pod_template_file.pyairflowPodSecurityContextandcontainerSecurityContextfunctions in_helpers.yamlto adjust them to reading nestedsecurityContextssectionsifforworkers.celery.persistence.securityContextssectionWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.