feat(echo): add a configurable experiment duration to the dev Echo app#691
Merged
Merged
Conversation
Add an Experiment_Duration input (default 60s) to the Echo application interface and route the deployment through a new echo_sleep wrapper that sleeps for the given duration before echoing the message. This lets Echo runs last long enough to exercise and observe the experiment progress pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Experiment_Durationinput (INTEGER, default 60s) to the Echo application interface, ordered before the message.conf/slurm/echo_sleepwrapper (sleep <duration>; echo <message>) instead of/bin/echo, so the job sleeps for the given duration before echoing. The wrapper is baked into the SLURM image.Test plan
/usr/local/bin/echo_sleep <duration> <message>; the job sleeps, then writesEcho.stdout= the message.