fix(devstack): make reset a true wipe and retry the ingress check#690
Merged
Merged
Conversation
devstack reset only ran `colima delete`, but colima keeps a persistent Lima data disk under _lima/_disks/<instance> (bind-mounted to /var/lib/docker) that survives the delete, so images, volumes and restart:unless-stopped containers resurrected on the next VM start. Remove that disk so reset is a true from-scratch wipe. Also wrap the verify gate's :443 check in a short retry loop so a freshly pulled / cold Traefik does not spuriously fail it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devstack resetonly rancolima delete, but colima keeps a persistent Lima data disk (_lima/_disks/<instance>, bind-mounted to/var/lib/docker) that survives the delete — so images, volumes andrestart: unless-stoppedcontainers resurrected on the next VM start. Reset now also removes that disk, making it a true from-scratch wipe.:443check in a short retry loop so a freshly pulled / cold Traefik doesn't spuriously fail it.Test plan
./devstack/devstack reset, then recreate the VM → docker reports 0 containers / 0 images / 0 volumes (previously old state resurrected)../devstack/devstack ensureagainst a cold, freshly-pulled Traefik → verify passes on the first run.tilt up(server + infra) + portal bring-up from scratch succeeds.