fix: fix repoContrib confusion (#2269) #2274
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportBase: 96.67% // Head: 96.67% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2274 +/- ##
=======================================
Coverage 96.67% 96.67%
=======================================
Files 22 22
Lines 3824 3824
Branches 322 322
=======================================
Hits 3697 3697
Misses 125 125
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This commit prevents confusion about the Contributed to stat. Currently, only the last year's results are shown, but it looks like it is the all-time contribution count (see #2269). This commit adds a ' (last year)' suffix to prevent this confusion from happening.
rickstaa
force-pushed
the
fix_repo_contrib_confusion
branch
from
877df5e to
dc60b1f
Compare
| 'g[transform="translate(0, 100)"]>.stagger>.stat.bold', | ||
| ).textContent, | ||
| ).toMatchInlineSnapshot(`"参与项目数:"`); | ||
| ).toMatchInlineSnapshot(`"参与项目数 (last year):"`); |
There was a problem hiding this comment.
The parenthesized （star）, （commit）, （PR）, and （issue） above are annotating the Chinese terms 星, 提交, 拉取请求, and 问题.
(last year) breaks parallelism both syntactically (half-width vs full-width parentheses) and semantically (should be "过去一年" rather than "last year").
I understand it's an i18n problem. Maybe worth tracking it somewhere? @anuraghazra
There was a problem hiding this comment.
@liyishuai, you are 100% correct. When I added that code, I didn't have time to implement the i18n translations; feel free to create an issue and implement a PR. I'm happy to review it. I think you should wait until #2053 (comment) is implemented since this will change the translation pipeline a bit.
This commit prevents confusion about the Contributed to stat. Currently, only the last year's results are shown, but it looks like it is the all-time contribution count (see anuraghazra#2269). This commit adds a ' (last year)' suffix to prevent this confusion from happening.
This commit prevents confusion about the Contributed to stat. Currently, only the last year's results are shown, but it looks like it is the all-time contribution count (see anuraghazra#2269). This commit adds a ' (last year)' suffix to prevent this confusion from happening.
This commit prevents confusion about the Contributed to stat. Currently, only the last year's results are shown, but it looks like it is the all-time contribution count (see anuraghazra#2269). This commit adds a ' (last year)' suffix to prevent this confusion from happening.
This commit prevents confusion about the Contributed to stat. Currently, only the last year's results are shown, but it looks like it is the all-time contribution count (see #2269). This commit adds a ' (last year)' suffix to prevent this confusion from happening.
Old card
New card