chore(release): v3.1.6-beta.20 #1419
Conversation
|
🎊 PR Preview 6948a83 has been successfully built and deployed to https://ant-design-ant-design-mini-preview-pr-1419.surge.sh 🕐 Build time: 281.311s
🤖 By surge-preview |
|
/release beta |
Deploying ant-design-mini with
|
| Latest commit: |
6948a83
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://792e8bf3.ant-design-mini.pages.dev |
| Branch Preview URL: | https://3-1-6-beta.ant-design-mini.pages.dev |
|
🎉 Release version 3.1.6-beta.1 publish successful! You can install this version via |
…n/ant-design-mini into refactor-component-constructor
…n/ant-design-mini into refactor-component-constructor
|
/release beta |
|
🎉 Release version 3.1.6-beta.2 publish successful! You can install this version via |
|
/release beta |
|
🎉 Release version 3.1.6-beta.3 publish successful! You can install this version via |
rayhomie
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
/release beta |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/_util/assert-component2.ts (1)
5-6: 改进的 component2 检测逻辑通过增加
typeof ac === 'object'条件，扩展了对 component2 特性的检测能力，使组件库在特定环境下更加健壮。但要注意以下几点：
- 使用
@ts-ignore注释抑制了类型检查，可能导致潜在类型问题被忽略- 全局变量
ac没有在此文件中声明，依赖于外部类型定义- 确保 typings.d.ts 中已正确声明了
ac变量的类型建议考虑添加注释说明此检测逻辑的目的和适用场景。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
package.json(2 hunks)src/_util/assert-component2.ts(1 hunks)src/mixins/value.ts(1 hunks)tsconfig.json(1 hunks)typings.d.ts(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- typings.d.ts
- tsconfig.json
- package.json
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: 🚀🚀🚀 Release Version
- GitHub Check: preview
- GitHub Check: build
- GitHub Check: build
- GitHub Check: Cloudflare Pages
🔇 Additional comments (1)
src/mixins/value.ts (1)
15-16: 扩展了 component2 检测条件与 assert-component2.ts 文件中的修改保持一致，通过
|| typeof ac === 'object'增强了特性检测逻辑。这有助于在支付宝环境中更可靠地识别 component2 特性的可用性。注意事项：
@ts-ignore的使用暂时解决了类型检查问题，但应确保ac变量在全局类型定义中正确声明- 该变更影响了条件编译块中的逻辑，对
didUpdate和didMount中的控制流有潜在影响- 与其他文件的修改保持同步，确保检测逻辑的一致性
请确认 typings.d.ts 文件中是否已经正确定义了全局变量
ac，以避免类型错误。
|
🎉 Release version 3.1.6-beta.17 publish successful! You can install this version via |
rayhomie
changed the title
|
/release beta |
|
🎉 Release version 3.1.6-beta.18 publish successful! You can install this version via |
rayhomie
changed the title
|
/release beta |
|
🎉 Release version 3.1.6-beta.19 publish successful! You can install this version via |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
package.json(2 hunks)src/Popup/index.ts(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- package.json
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build
- GitHub Check: Cloudflare Pages
src/Popup/index.ts
Outdated
| @@ -59,7 +59,7 @@ Component({ | |||
| const enableAnimation = animation && duration > 0; | |||
|
|
|||
| if ( | |||
| nextProps.visible !== visible && | |||
| Boolean(nextProps.visible) !== Boolean(visible) && | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
布尔值转换提升了类型安全性，但需要保持一致性
这个改动很好，使用 Boolean() 确保了严格的布尔值比较，避免了真值/假值但非严格布尔类型可能带来的问题。
但是注意到代码中存在不一致的地方：第77行的 didUpdate 方法仍然使用直接比较 prevProps.visible !== visible。建议在整个文件中保持一致的比较方式。
应用以下修改以保持一致性：
- if (prevProps.visible !== visible && !enableAnimation) {
+ if (Boolean(prevProps.visible) !== Boolean(visible) && !enableAnimation) {📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Boolean(nextProps.visible) !== Boolean(visible) && | |
| // In src/Popup/index.ts, within the `didUpdate` method | |
| protected didUpdate(prevProps: PopupProps, prevState: PopupState, enableAnimation: boolean) { | |
| const { visible } = this.state; | |
| - if (prevProps.visible !== visible && !enableAnimation) { | |
| + if (Boolean(prevProps.visible) !== Boolean(visible) && !enableAnimation) { | |
| this.setState({ triggerAnimation: true }); | |
| } | |
| // …rest of logic | |
| } |
🤖 Prompt for AI Agents
In src/Popup/index.ts at line 77, the didUpdate method uses direct comparison
prevProps.visible !== visible, which is inconsistent with line 62 where
Boolean() is used for strict boolean comparison. Update the comparison in
didUpdate to use Boolean(prevProps.visible) !== Boolean(visible) to maintain
consistent and type-safe boolean comparisons throughout the file.
|
/release beta |
|
🎉 Release version 3.1.6-beta.20 publish successful! You can install this version via |
Summary by CodeRabbit
新功能
修复
样式
其他