Skip to content

axial_fan_performance_curve#440

Open
Mustafa-Kaddoura wants to merge 8 commits into
mainfrom
Mustafa-Kaddoura
Open

axial_fan_performance_curve#440
Mustafa-Kaddoura wants to merge 8 commits into
mainfrom
Mustafa-Kaddoura

Conversation

@Mustafa-Kaddoura

Copy link
Copy Markdown

Caution

Do not commit any proprietary information belonging either to Ansys or to external sources. If you are uncertain, consult your manager.

Important

This repository used to have as its default branch master. In order to align with the ecosystem
standards, the default branch's name has been changed for main. The previous master branch is
left for avoiding breaking changes on our libraries, and it is being kept in sync with main. Make sure
that any PR opened is targeting main.

@RobPasMue

RobPasMue commented Jul 1, 2026

Copy link
Copy Markdown
Member

@Mustafa-Kaddoura - the content in this PR is effectively empty. Are you sure you want to merge this? If not please proceed to close the PR

@ansys-cla-bot

ansys-cla-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

** ⚠️ CLA Check Failed: Commit Author Verification Unsuccessful**

One or more commits in this pull request contain missing or invalid author information. This issue may arise due to:

  • A change in the contributor's GitHub username
  • Deletion of the contributor's GitHub account
  • Corruption or alteration of commit author metadata
  • A co-authored commit where the co-author's GitHub username can't be retrieved

Commits with unknown or invalid author information:

Please update the commit author details and force-push the updated commit to proceed with the CLA verification.

Note

Action Required: Repository maintainers with write access can trigger a recheck by commenting
@cla-bot rerun
Please contact the maintainers to rerun the CLA check after the missing signatures have been captured.

@Mustafa-Kaddoura

Copy link
Copy Markdown
Author

Hello @RobPasMue
I have uploaded a Jupyter notebook along with the mesh file to the directory.
Thank you.

@RobPasMue

Copy link
Copy Markdown
Member

Hi @Mustafa-Kaddoura - this repository is only intended to hold simulation files, not scripts which perform a simulation. I would encourage you to migrate the Jupyter NB to the PyFluent examples if you prefer, but we should not be hosting them in this repository. Hope you understand =)

@Mustafa-Kaddoura

Copy link
Copy Markdown
Author

Hi @RobPasMue - thank you for the clarification. It's my first time to work on this repo.
The dir now only include simulation files. I have migrated the Jupyter NB to the Pyfluent examples.

@RobPasMue

Copy link
Copy Markdown
Member

Awesome, thanks a lot @Mustafa-Kaddoura - can you confirm as well that all this content is fine to be made publicly available?

@RobPasMue

RobPasMue commented Jul 3, 2026

Copy link
Copy Markdown
Member

JSYK - I can still see the Jupyter NB and the snapshots. I believe you want to delete them based on your previous comment

image

@Mustafa-Kaddoura

Copy link
Copy Markdown
Author

Hi @RobPasMue , yes it is generic and can be publicly available.
I'm interested to work with the team to have this example accessible on the PyFluent Examples page so it's more visual to customers https://fluent.docs.pyansys.com/version/stable/examples/index.html

@Mustafa-Kaddoura

Copy link
Copy Markdown
Author

@RobPasMue Could you guide me where to upload my Jupyter NB for the team to review?

I have now two new directories:

  1. Pyfluent/axial_fan_perfromance_curve: this only contains simulation files.
  2. Pyfluent/examples/axial_fan_performance_curve: this includes NB and schematic only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants