Skip to content

fix(login): don't hang on network errors #19629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukstbit merged 3 commits into from
Nov 27, 2025
Merged

fix(login): don't hang on network errors #19629

lukstbit merged 3 commits into from
Nov 27, 2025

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Nov 27, 2025 •
edited
Loading

Purpose / Description

I had a bad emulator, I tried to log in and the operation hung

Fixes

Approach

Catch the exception and display it

How Has This Been Tested?

Pixel 9 API 35 Emulator: couldn't connect to AnkiWeb as the internet was borked

Screenshot 2025-11-27 at 16 49 36

Learning

Cause:

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison
fix(login): don't hang on network errors
beee385 
`handleLogin` threw `BackendNetworkException`
`ThrowableFilterService` filtered the exception

So the exception was unhandled and did not crash, leading to a hang

fix: catch the exception & display it

Caused by: PR 17908 - 48a5557
* Unhandled exception thrown

Caused by: PR 17402 - 333ef64 - Issue 17392
* Unhandled exception not processed correctly

Fixes 19627
@david-allison
chore(login): add logs
e2b1987
@david-allison
refactor(login): IDE lint
e0ba242
@david-allison david-allison added the Review High Priority Request for high priority review label Nov 27, 2025
@david-allison david-allison added this to the 2.23 release milestone Nov 27, 2025
@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Nov 27, 2025
@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Nov 27, 2025
@lukstbit lukstbit added this pull request to the merge queue Nov 27, 2025
Merged via the queue into ankidroid:main with commit 1c8b9f2 Nov 27, 2025
18 checks passed
@github-actions github-actions bot removed Review High Priority Request for high priority review Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) labels Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukstbit lukstbit lukstbit approved these changes

@BrayanDSO BrayanDSO BrayanDSO approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.23 release

Development

Successfully merging this pull request may close these issues.

[BUG] Login: Exceptions are no longer displayed to user

3 participants

@david-allison @lukstbit @BrayanDSO