Skip to content

fix(google-maps): fix update schematic #31448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

fix(google-maps): fix update schematic #31448

merged 1 commit into from
Jun 26, 2025

Conversation

terencehonles
Copy link
Contributor

@terencehonles terencehonles commented Jun 26, 2025 •
edited
Loading

This change fixes the updateToV20 schematic which should be a factory function not the schematic itself.

Fixes the error:

❯ Updates the Angular Google Maps package to v20.                                                                                                      
✖ Migration failed: rule is not a function                                                                                                             
  See "/tmp/ng-1KmdDK/angular-errors.log" for further details.

@terencehonles
fix(google-maps): fix update schematic
279340e 
This change fixes the `updateToV20` schematic which should be a factory function not the schematic itself.
@terencehonles terencehonles requested a review from a team as a code owner June 26, 2025 07:19
@terencehonles terencehonles requested review from crisbeto and ok7sai and removed request for a team June 26, 2025 07:19
@crisbeto crisbeto removed the request for review from ok7sai June 26, 2025 07:34
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 26, 2025
@crisbeto crisbeto merged commit 4052130 into angular:main Jun 26, 2025
27 of 29 checks passed
@crisbeto
Copy link
Member

The changes were merged into the following branches: main, 20.0.x

crisbeto pushed a commit that referenced this pull request Jun 26, 2025
@terencehonles @crisbeto
fix(google-maps): fix update schematic (#31448)
bdfeb04 
This change fixes the `updateToV20` schematic which should be a factory function not the schematic itself.

(cherry picked from commit 4052130)
@terencehonles terencehonles deleted the patch-1 branch June 26, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: google-maps target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terencehonles @crisbeto