fix(material/radio): required attribute being set on buttons#31163
Open
andrewseguin wants to merge 1 commit into
Open
fix(material/radio): required attribute being set on buttons#31163andrewseguin wants to merge 1 commit into
andrewseguin wants to merge 1 commit into
Conversation
fixes when `MatRadioGroup` is set to be required it was setting all of its `MatRadioButton` to be required as-well which is confusing for assistive technologies, this commit ensures we only set aria-required on group rather than all buttons unless button is being used standalone of `MatRadioGroup` fixes angular#30399
andrewseguin
requested review from
adolgachev and
crisbeto
and removed request for
a team
May 20, 2025 18:09
mmalerba
reviewed
May 21, 2025
| // we never want to set required attribute on input when we have MatRadioGroup as we will set | ||
| // aria-required directly on MatRadioGroup if its required as setting on all MatRadioButton for | ||
| // it's MatRadioGroup would be confusing for assistive technology. | ||
| if (this.radioGroup) return null; |
Contributor
There was a problem hiding this comment.
Why is this null instead of false, but when we're setting it according to this.required we don't do || null? Is there a difference between aria-required="false" and just not having the attribute?
adolgachev
removed their request for review
July 21, 2025 22:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes when
MatRadioGroupis set to be required it was setting all of itsMatRadioButtonto be required as-well which is confusing for assistive technologies, this commit ensures we only set aria-required on group rather than all buttons unless button is being used standalone ofMatRadioGroupfixes #30399