fix(amp-slikeplayer): add amp param to video URL and fullscreen/GDPR support#40521
Open
SlikeTech wants to merge 3 commits into
Open
fix(amp-slikeplayer): add amp param to video URL and fullscreen/GDPR support#40521SlikeTech wants to merge 3 commits into
SlikeTech wants to merge 3 commits into
Conversation
Integrate AMP consent framework so the Slike player iframe can request and receive consent data via postMessage, enabling cleo-player to handle personalisation and analytics decisions based on user consent state. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
erwinmombay
approved these changes
Jun 30, 2026
Member
|
@danielrozenberg looks like bundle size has been running for a day now |
Member
|
Looks like CircleCI hasn't started on this PR at all which is why the bundle size check hasn't started (or finished) - I want to see if closing and reopening this PR will cause it to run CircleCI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
amp-slikeplayerextension:&=1to the player iframesrcinlayoutCallback()(both default and config code paths) so the player can detect it is running inside an AMP context.postMessagetarget instead of'*'.fullscreenEnter()/fullscreenExit()overrides using#core/dom/fullscreen.amp-slikeplayer.Files
extensions/amp-slikeplayer/0.1/amp-slikeplayer.jsTest
amp=1parameter present in the iframe URL.