-
-
Notifications
You must be signed in to change notification settings - Fork 17
Fix League\Uri\Http deprecation warning #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes this warning:
```
User Deprecated: Method League\Uri\Http::createFromString()
is deprecated since league/uri:7.0.0, use League\Uri\Http::new() instead
```
|
This needs a change in composer.json to drop 6.x support, no? |
|
@kelunik You are right. Didn't notice that earlier. Should I add the change? |
|
The fix looks good, but it's missing the required To complete this PR, line 39 in "league/uri": "^6.8|^7.1",to: "league/uri": "^7.1",This change is necessary because I've documented this issue thoroughly here: https://github.com/eduwass/deprecated-repro @foxycode Would you like to add this change to your PR, or would you prefer if I submitted the complete fix in a new PR? This is affecting Pest v4 browser testing users, so it would be great to get this resolved. See: pestphp/pest#1470 |
|
And tagged a new release, v2.0.2 is out now. :-) |
|
Just tested! The issue I was running into ( pestphp/pest#1470 ) is now fixed, thanks for the quick turnaround @kelunik 👏 |
|
Awesome, thank you guys |
Fixes this warning: