Skip to content

Add cross-platform build scripts and update documentation for workflows#27

Merged
amirisback merged 10 commits into
masterfrom
release/2.2.7
Apr 6, 2026
Merged

Add cross-platform build scripts and update documentation for workflows#27
amirisback merged 10 commits into
masterfrom
release/2.2.7

Conversation

@amirisback

Copy link
Copy Markdown
Owner

No description provided.

@amirisback amirisback self-assigned this Apr 6, 2026
@amirisback amirisback added the enhancement New feature or request label Apr 6, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 238700f23f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread script/build.sh
Comment on lines +1 to +4
#!/bin/bash

# Navigate to the project root directory
cd "$(dirname "$0")/.."

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Exit shell build script on first Gradle failure

The script never enables fail-fast mode (for example set -e), so if any ./gradlew ... step fails, execution continues to later steps and still prints a successful completion banner. In CI or other automation that invokes this script, a failing build/test can be reported as success because the script’s final exit status comes from the last echo command instead of the failed Gradle command.

Useful? React with 👍 / 👎.

Comment thread script/build.bat
echo ======================================

echo [1/6] Cleaning project...
call gradlew clean

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Propagate Gradle failures in Windows build script

Each call gradlew ... invocation ignores %ERRORLEVEL%, so a failed Gradle task does not stop the script and it still reaches the success message (and pause) with a zero exit code. This can mask broken builds/tests in automated runs on Windows because callers cannot reliably detect task failure from the script result.

Useful? React with 👍 / 👎.

@amirisback amirisback merged commit 14c4bc9 into master Apr 6, 2026
5 of 6 checks passed
@amirisback amirisback deleted the release/2.2.7 branch April 6, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

1 participant