Add allowedFramingOrigins for MeshCentral clickjacking protection#2417
Open
JonBons wants to merge 1 commit intoamidaware:developfrom
Open
Add allowedFramingOrigins for MeshCentral clickjacking protection#2417JonBons wants to merge 1 commit intoamidaware:developfrom
JonBons wants to merge 1 commit intoamidaware:developfrom
Conversation
Replace allowFraming: true with allowedFramingOrigins so only the TacticalRMM frontend can embed MeshCentral in iframes, addressing potential clickjacking. - install.sh: use allowedFramingOrigins with frontend domain - Docker: add allowedFramingOrigins from APP_HOST (empty array if unset) - Ansible mesh.cfg.j2: add allowedFramingOrigins for prod and dev (port 8080) - update.sh: migrate existing allowFraming configs to allowedFramingOrigins - Skip when FRONTEND is empty or mesh config is missing - Add backup and warning on migration failure
|
|
JonBons
changed the title
Author
|
MeshCentral changes that this PR is dependent on is now released in version 1.1.57. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
allowFramingwithallowedFramingOriginsfor default config so only the TacticalRMM frontend can embed MeshCentral in iframes, addressing potential clickjacking. (See PR for MeshCentral changes Ylianst/MeshCentral#7599, was released in version 1.1.57 of MeshCentral)allowedFramingOriginswith frontend domainallowedFramingOriginsfromAPP_HOST(empty array if unset)allowedFramingOriginsfor prod and dev (port 8080)allowFramingconfigs toallowedFramingOrigins