Replace mongodb with postgres#1578
Draft
joeldeteves wants to merge 1 commit intoamidaware:developfrom
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1578 +/- ##
========================================
Coverage 80.56% 80.56%
========================================
Files 118 118
Lines 7884 7884
========================================
Hits 6352 6352
Misses 1532 1532 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
this has been completed @wh1te909 could maybe close this? thanks @joeldeteves |
Member
|
this should not be closed...docker builds still use mongo. still need a migration script for docker users for mongo to postgres then can probably merge this. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey guys, this one does require some testing.
I did not have time to build all containers locally and test - I was only able to verify basic deployment by running a docker-compose.
Please build and test at your discretion; we may need to script something to create the default 'postgres' database for example if MeshCentral doesn't spin up.
Other than that, all the environment variables in the start script from the Discord chat are there; I am using in prod right now in my k8s and it works with my Postgres DB which is not in the cluster, so slightly different setup (I did my best to update the docker setup accordingly).
Let me know how it looks