chore(dependency) Dependency updates#360
Open
work933k wants to merge 3 commits intoamericanexpress:mainfrom
Open
chore(dependency) Dependency updates#360work933k wants to merge 3 commits intoamericanexpress:mainfrom
work933k wants to merge 3 commits intoamericanexpress:mainfrom
Conversation
Member
|
@work933k Thanks for the contribution. Some other work has been merged between your other PR and this one. The conflicts in the workflows and package.json are trivial, but i can't resolve them manually in the package-lock.json. Please merge main into your branch and resolve the conflicts |
10 tasks
benmccann
reviewed
Jan 7, 2025
| } else { | ||
| const receivedSnapshotPath = path.join(receivedDir, `${snapshotIdentifier}${receivedPostfix}.png`); | ||
| rimraf.sync(receivedSnapshotPath); | ||
| rimrafSync(receivedSnapshotPath, { glob: true }); |
There was a problem hiding this comment.
glob: true is not necessary. also, you can remove rimraf entirely and remove the files with rmSync(path, { recursive: true, force: true }); from Node.js. rimraf has 27 dependencies, so it'd be nice to use a slimmer solution
this is being done in #358
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Be aware! That i based this PR on my other PR (#359).
I updated package dependencies which were "easy" to update and needed little code refactoring.
I migrated from Husky v4 to v9 which needed some script tweaks.
Also updated
rimrafwhich needed some refactoring.I chose not to upgrade ESLint in this PR as this introduced quite some code issues.
I also chose not to upgrade some dependency which resulted in ESM/CommonJS issues.
Motivation and Context
We activly make use of this package and would be kept up-to-date.
How Has This Been Tested?
Yes. Tested with the unit-tests.
Types of Changes
Checklist:
What is the Impact to Developers Using Jest-Image-Snapshot?
I don't expect that this would introduce issues for developers/users of this package.