-
Notifications
You must be signed in to change notification settings - Fork 69
Deprecate support for python 3.10 #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It causes SSL/TLS issues on older Ubuntu LTS releases.
Summary of ChangesHello @loganaden, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses compatibility issues, specifically related to SSL/TLS, that arise when using Python 3.10 on older Ubuntu LTS releases. By raising the minimum required Python version to 3.11, the project aims to ensure a more stable and secure environment for its users, mitigating the reported SSL/TLS problems. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request aims to deprecate support for Python 3.10 by updating the minimum required version to 3.11, which is a necessary change to address SSL/TLS issues. The modification in pyproject.toml is correct. I have added one comment suggesting a corresponding update to the ruff configuration to ensure the linter targets the new minimum Python version. This will maintain consistency in the development environment.
| authors = [{name = "DeepFabric Team", email = "[email protected]"}] | ||
| readme = "README.md" | ||
| requires-python = ">=3.10" | ||
| requires-python = ">=3.11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It causes SSL/TLS issues on older Ubuntu LTS releases.