Skip to content

[1.3] Gitlab CI: enable test for the SYCL CPU backend #2462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jan 26, 2025

No description provided.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 26, 2025

/builds/hzdr/crp/alpaka/test/unit/vec/src/VecTest.cpp:479:1: error: passing no argument for the '...' parameter of a variadic macro is a C++20 extension [-Werror,-Wc++20-extensions]

Mhm, looks like we cannot enable this for the 1.3.0 branch then.

@SimeonEhrig
Copy link
Member

/builds/hzdr/crp/alpaka/test/unit/vec/src/VecTest.cpp:479:1: error: passing no argument for the '...' parameter of a variadic macro is a C++20 extension [-Werror,-Wc++20-extensions]

Mhm, looks like we cannot enable this for the 1.3.0 branch then.

That's strange. Before we could compile it with ICPX 2024.2 and C++17. If I'm not wrong, you only changed the OneAPI version and did not install the Open-CL Runtime anymore.

@SimeonEhrig
Copy link
Member

@fwyzard I spent some time with the issue. The update to OneAPI 2025 causes the problem. The new compiler throws this warning, which becomes an error because of our build configuration. There is already a catch2 issue for it: catchorg/Catch2#2910
So ether we wait for the fix and update or we suppress the warning for targets using catch2.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 28, 2025

So ether we wait for the fix and update or we suppress the warning for targets using catch2.

I see.

I would propose to suppress the warning, until the fix is merged in CMake or if we use a version without the fix.

@SimeonEhrig
Copy link
Member

I would propose to suppress the warning, until the fix is merged in CMake or if we use a version without the fix.

I agree. It's working with warning and the warning will be gone, when we move to C++20. I will work on a CMake fix for our alpaka CMake.

@SimeonEhrig
Copy link
Member

@fwyzard Can you please apply the patch on your branch. This suppress the warning and should fix the problem.
0001-suppress-c-20-extension-warning-if-ICPX-2025-and-C-1.zip

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 29, 2025

@SimeonEhrig thank you for the patch.

Do you know if clang 19 would have the same issue ?

@SimeonEhrig
Copy link
Member

SimeonEhrig commented Jan 29, 2025

@SimeonEhrig thank you for the patch.

Do you know if clang 19 would have the same issue ?

I think so. I can test it later, if you don't have a clang 19.
Clang 19 has the same problem.

@SimeonEhrig
Copy link
Member

@fwyzard I extended the patch for clang 19. You need to revert the patch.
0001-suppress-c-20-extension-warning-if-ICPX-2025-and-C-1.zip

@fwyzard fwyzard force-pushed the enableSyclCPURuntimeCI_130 branch from 7bf0884 to 51077df Compare January 29, 2025 12:37
@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 29, 2025

@fwyzard I extended the patch for clang 19. You need to revert the patch. 0001-suppress-c-20-extension-warning-if-ICPX-2025-and-C-1.zip

@SimeonEhrig thank you for the update.

@SimeonEhrig
Copy link
Member

@fwyzard Now trigger the wrap-test bug also here: #2464 (comment)

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 29, 2025

Yes... unfortunately that looks to be a real issue: #2464 (comment) .

@fwyzard fwyzard changed the title [13] Gitlab CI: enable test for the SYCL CPU backend [1.3] Gitlab CI: enable test for the SYCL CPU backend Jan 30, 2025
@SimeonEhrig
Copy link
Member

I merge after #2469 is merged.

@fwyzard fwyzard added this to the 1.3.0 milestone Jan 30, 2025
@fwyzard fwyzard force-pushed the enableSyclCPURuntimeCI_130 branch from 2d0d555 to 18ef48a Compare January 30, 2025 20:43
@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 30, 2025

(rebased to fix the conflicts)

@fwyzard fwyzard merged commit fc30087 into alpaka-group:develop-1.3.0 Jan 30, 2025
1 of 3 checks passed
@fwyzard fwyzard deleted the enableSyclCPURuntimeCI_130 branch January 30, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants