feat(parquet): support pushing bitmaps down to page-level filtering (except for nested columns)#375
Merged
Merged
Conversation
lxy-9602
reviewed
Jun 21, 2026
…ousBatchFirstRowId to GetGlobalRowId
lxy-9602
reviewed
Jul 9, 2026
zjw1111
reviewed
Jul 9, 2026
zjw1111
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the follow-up work on page-level bitmap pushdown, and for the solid test coverage. A few follow-up nits on stale comments and naming, on top of the points already raised in the earlier review.
zjw1111
reviewed
Jul 10, 2026
zjw1111
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the quick updates — most of the earlier comments are addressed. Two small follow-ups below.
zjw1111
approved these changes
Jul 10, 2026
zjw1111
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the thorough follow-ups and the added test coverage. All review comments are addressed. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR follows PR #371.
TargetRowGrouptype to carry row-group index, partial-match status, row ranges, and read-range exclusion flags consistently across planning and reading phases.Changes
src/paimon/format/parquet/target_row_group.hTargetRowGroupclass andTargetRowGroupsalias.row_ranges.h.src/paimon/format/parquet/parquet_file_batch_reader.hTargetRowGroupsinstead of rawstd::vector<int32_t>.src/paimon/format/parquet/parquet_file_batch_reader.cppSetReadSchema, switched row-group candidate list toTargetRowGroupsand applied bitmap filter before page-index filtering.Tests
BitmapAllPagesSomeRowGroupsBitmapPartialPagesSingleRowGroupBitmapAllAndPartialPagesMixedBitmapAllPagesWithPredicateBitmapPartialPagesWithPredicateBitmapMixedWithPredicateNestedMapBitmapFallbackNestedListBitmapFallbackNestedStructBitmapFallbackDatasets
Multiple performance testing were conducted on 2 dataset.
Test Methodology
To validate bitmap behavior, we organize tests into six groups based on bitmap distribution patterns. Each group contains five distinct datasets, and the final result reported is the average of these five runs.
Test Cases
1010101010...).Test Results
On Dataset#1
On Dataset#2
API and Format
Documentation
Generative AI tooling