Prepare fullscreen support

[jnschulze]

@alexmercerind
I was a bit tired of arguing, so I made this proposal showing how fullscreen handling might be decoupled from the Video widget.

It allows you to pass an optional FullscreenController upon creating a Video widget:

Video(player: _player, fullscreenController: MyFullscreenController());

The button for toggling fullscreen will only appear if a controller was provided. (I've just added your proposed button from yesterday's PR)

A very basic implementation using your window_size fork might look like

class MyFullscreenController extends FullscreenController {
  @override
  void toggleFullscreen() {
    final isFullscreen = value.isFullscreen;
    if (isFullscreen) {
      window.exitFullscreen();
    } else {
      window.enterFullscreen();
    }

    value = value.copyWith(isFullscreen: !value.isFullscreen);
  }
}

[panoti]

I think you should separate refactor code and fullscreen code in different pull requests.

[panoti]

I found that you import controls without using it. All codes below are just for refactor purpose.

[panoti]

why we don't keep old position?

[alexmercerind]

Adding an additional button certainly needs more space, infact this UI code wasn't written by me but a contributor. Ideally, one would write their own custom designed video controls. These "just work" and are very "generic" & here to show the plugin capabilities etc. in the example itself.

[panoti]

I think you should have separately a refactor pull request. Mix refactors and fullscreen feature makes difficult to track the codes

[jnschulze]

@panoti

I think you should separate refactor code and fullscreen code in different pull requests.

I don't know who you are and what qualifies you to comment on this. But to give you some context: This PR isn't intended do be merged as is but was rather a response to #127 as a proposal showing how to abstract fullscreen handling. The changed right/bottom offsets were blindly copied from the other PR.

[panoti]

@panoti
I don't know who you are and what qualifies you to comment on this. But to give you some context: This PR isn't intended do be merged as is but was rather a response to #127 as a proposal showing how to abstract fullscreen handling. The changed right/bottom offsets were blindly copied from the other PR.

I only contribute in the spirit of open source. I found your pull request very useful and it's missing from the library, I installed dart_vlc and can't find the fullscreen control. I think the author can do a faster review for your pull request and we will have fullscreen feature in the next version. If you are annoyed by some of my comments, I am very sorry.

[alexmercerind]

@panoti
I don't know who you are and what qualifies you to comment on this. But to give you some context: This PR isn't intended do be merged as is but was rather a response to #127 as a proposal showing how to abstract fullscreen handling. The changed right/bottom offsets were blindly copied from the other PR.

I only contribute in the spirit of open source. I found your pull request very useful and it's missing from the library, I installed dart_vlc and can't find the fullscreen control. I think the author can do a faster review for your pull request and we will have fullscreen feature in the next version. If you are annoyed by some of my comments, I am very sorry.

Most presumably, fullscreen will never be part of this plugin. Its NOT a libVLC feature or exposition but a Flutter / OS thing. (You are not making video output fullscreen but the window).

I made the PR for adding fullscreen to window_size but as Stuart Morgan said, another plugin window_manager implements the same I did in that PR. (Use that).
I expect users to implement their own fullscreen logic now. Infact this PR itself doesn't contain any fullscreen switching code, but a controller to implement own logic (and native calls) (as there might be other plugins that change window style/state. Thus, it can be breaking in some cases for users).

This PR is still open just as a "draft" to discuss more about this in future or possibly change the plans.

[panoti]

@alexmercerind

Thanks for your useful info. I should probably start with dart_vlc_ffi and try to implement a custom control.

[alexmercerind]

@alexmercerind

Thanks for your useful info. I should probably start with dart_vlc_ffi and try to implement a custom control.

dart_vlc_ffi in itself has no meaning to use in Flutter. Its just for Dart CLI (...if someone really wanna use Dart only) & has no native code in it either. Its just FFI mapping & I just decided to split the package into two.

You don't need anything special.