feat(NbDialogService): support passing values to input/model signals#3278
Open
junglerobba wants to merge 1 commit intoakveo:masterfrom
Open
feat(NbDialogService): support passing values to input/model signals#3278junglerobba wants to merge 1 commit intoakveo:masterfrom
junglerobba wants to merge 1 commit intoakveo:masterfrom
Conversation
junglerobba
force-pushed
the
dialog-signal-inputs
branch
from
cd6048d to
3209993
Compare
|
Contributor
|
Any change this gets merged @denStrigo? |
junglerobba
force-pushed
the
dialog-signal-inputs
branch
from
3209993 to
0bcabdf
Compare
|
Contributor
|
Can this one be reviewed and merged please @denStrigo ? |
This makes an exception for input and model signals in the DialogConfig context, so the typehint will show as the type of the signal's value, but internally it will create a signal with the passed value. Technically these will just be readonly signals instead of input or model signals, but since components used as a dialog do not support regular outputs anyway, it should not matter. When used in a regular context the input signal will not be overwritten and work as usual. closes akveo#3256 (I would not classify this as a bug but a missing feature instead)
junglerobba
force-pushed
the
dialog-signal-inputs
branch
from
0bcabdf to
f6aeb96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes an exception for input and model signals in the DialogConfig context, so the typehint will show as the type of the signal's value, but internally it will create a signal with the passed value. Technically these will just be readonly signals instead of input or model signals, but since components used as a dialog do not support regular outputs anyway, it should not matter. When used in a regular context the input signal will not be overwritten and work as usual.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
closes #3256 (I would not classify this as a bug but a missing feature instead)