-
Notifications
You must be signed in to change notification settings - Fork 266
feat: implement resource reclamation #2065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| --- | ||
| name: guidelines | ||
| description: Behavioral guidelines to reduce common LLM coding mistakes. Use when writing, reviewing, or refactoring code to avoid overcomplication, make surgical changes, surface assumptions, and define verifiable success criteria. | ||
| license: MIT | ||
| --- | ||
|
|
||
| # Guidelines | ||
|
|
||
| **Tradeoff:** These guidelines bias toward caution over speed. For trivial tasks, use judgment. | ||
|
|
||
| ## 1. Think Before Coding | ||
|
|
||
| **Don't assume. Don't hide confusion. Surface tradeoffs.** | ||
|
|
||
| Before implementing: | ||
| - State your assumptions explicitly. If uncertain, ask. | ||
| - If multiple interpretations exist, present them - don't pick silently. | ||
| - If a simpler approach exists, say so. Push back when warranted. | ||
| - If something is unclear, stop. Name what's confusing. Ask. | ||
|
|
||
| ## 2. Simplicity First | ||
|
|
||
| **Minimum code that solves the problem. Nothing speculative.** | ||
|
|
||
| - No features beyond what was asked. | ||
| - No abstractions for single-use code. | ||
| - No "flexibility" or "configurability" that wasn't requested. | ||
| - No error handling for impossible scenarios. | ||
| - If you write 200 lines and it could be 50, rewrite it. | ||
|
|
||
| Ask yourself: "Would a senior engineer say this is overcomplicated?" If yes, simplify. | ||
|
|
||
| ## 3. Surgical Changes | ||
|
|
||
| **Touch only what you must. Clean up only your own mess.** | ||
|
|
||
| When editing existing code: | ||
| - Don't "improve" adjacent code, comments, or formatting. | ||
| - Don't refactor things that aren't broken. | ||
| - Match existing style, even if you'd do it differently. | ||
| - If you notice unrelated dead code, mention it - don't delete it. | ||
|
|
||
| When your changes create orphans: | ||
| - Remove imports/variables/functions that YOUR changes made unused. | ||
| - Don't remove pre-existing dead code unless asked. | ||
|
|
||
| The test: Every changed line should trace directly to the user's request. | ||
|
|
||
| ## 4. Goal-Driven Execution | ||
|
|
||
| **Define success criteria. Loop until verified.** | ||
|
|
||
| Transform tasks into verifiable goals: | ||
| - "Add validation" → "Write tests for invalid inputs, then make them pass" | ||
| - "Fix the bug" → "Write a test that reproduces it, then make it pass" | ||
| - "Refactor X" → "Ensure tests pass before and after" | ||
|
|
||
| For multi-step tasks, state a brief plan: | ||
| ``` | ||
| 1. [Step] → verify: [check] | ||
| 2. [Step] → verify: [check] | ||
| 3. [Step] → verify: [check] | ||
| ``` | ||
|
|
||
| Strong success criteria let you loop independently. Weak criteria ("make it work") require constant clarification. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| --- | ||
| name: upgrade-changelog | ||
| description: "Generates CHANGELOG.md entries for upgrade versions found in upgrades/software/ by parsing init.go and upgrade.go" | ||
| --- | ||
| # Instructions | ||
|
|
||
| Generate changelog entries in `upgrades/CHANGELOG.md` for any upgrade version under `upgrades/software/` that doesn't already have an entry. | ||
|
|
||
| ## Steps | ||
|
|
||
| 1. **Find semver directories** — list all directories under `upgrades/software/` whose names match `v<major>.<minor>.<patch>` (e.g., `v2.0.0`, `v1.0.0`). | ||
|
|
||
| 2. **Read `upgrades/CHANGELOG.md`** — identify which versions already have entries by scanning for `##### vX.Y.Z` headings. If a version already has a heading, skip it entirely. | ||
|
|
||
| 3. **For each new version** (no existing heading), gather data from two files: | ||
|
|
||
| ### 3a. Parse `upgrades/software/<version>/init.go` | ||
|
|
||
| Find all `utypes.RegisterMigration(...)` calls. Each call has the form: | ||
| ```go | ||
| utypes.RegisterMigration(moduleName, version, handlerFn) | ||
| ``` | ||
| - `moduleName` is a Go constant (e.g., `dv1.ModuleName`). Resolve it: | ||
| 1. Find the import alias (e.g., `dv1 "pkg.akt.dev/go/node/deployment/v1"`) | ||
| 2. Search the imported package for `ModuleName` constant definition to get the actual string value | ||
| - `version` is a `uint64` — this is the **from** version. The **to** version is `version + 1`. | ||
| - Record each migration as: `moduleName version -> version+1` | ||
|
|
||
| ### 3b. Parse `upgrades/software/<version>/upgrade.go` | ||
|
|
||
| Find the `StoreLoader()` method. It returns a `*storetypes.StoreUpgrades` struct with optional fields: | ||
| - `Added: []string{...}` — new stores | ||
| - `Renamed: []storetypes.StoreRename{...}` — renamed stores | ||
| - `Deleted: []string{...}` — removed stores | ||
|
|
||
| If `StoreLoader()` returns `nil`, there are no store changes. | ||
|
|
||
| For each store key constant (e.g., `epochstypes.StoreKey`, `ttypes.ModuleName`): | ||
| 1. Find the import alias in the file | ||
| 2. Search the imported package for the constant definition to get the actual string value | ||
|
|
||
| 4. **Insert the new entry** in `upgrades/CHANGELOG.md` immediately after the line: | ||
| ``` | ||
| Add new upgrades after this line based on the template above | ||
| ``` | ||
|
troian marked this conversation as resolved.
|
||
| followed by `-----`. | ||
|
|
||
| Use this format (newest entries go first, right after the delimiter): | ||
|
|
||
| ```markdown | ||
|
|
||
| ##### vX.Y.Z | ||
|
|
||
| ###### Description | ||
|
|
||
| - Stores | ||
| - added | ||
| - `storeName`: brief description if available | ||
| - renamed | ||
| - `oldName` -> `newName` | ||
| - deleted | ||
| - `storeName`: brief description if available | ||
|
|
||
| - Migrations | ||
| - moduleName `from -> to` | ||
| ``` | ||
|
|
||
| **Omission rules** (match existing CHANGELOG style): | ||
| - Omit the entire `Stores` section if there are no added, renamed, or deleted stores | ||
| - Omit `added`/`renamed`/`deleted` subsections individually if empty | ||
| - Omit the entire `Migrations` section if there are no migrations | ||
| - Always include the `###### Description` heading (leave it for the user to fill in) | ||
|
|
||
| 5. **Report results** — list each version processed and what was added. For skipped versions (already in CHANGELOG), mention they were skipped. | ||
|
|
||
| ## Important notes | ||
|
|
||
| - Store key constants may be named `StoreKey` or `ModuleName` — both are used as store identifiers. Resolve whichever constant appears in the code. | ||
| - When resolving Go constants from external packages, search under the Go module cache or use `go doc` if needed. The packages typically follow the pattern `pkg.akt.dev/go/node/<module>/<version>`. | ||
| - If a constant cannot be resolved, use the raw Go expression as a placeholder (e.g., `` `epochstypes.StoreKey` ``) and warn the user. | ||
| - Multiple versions may need entries — process them all in one run, inserting newest first after the delimiter. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a language tag to the fenced code block (markdownlint MD040).
Line 59 opens a fenced block without a language identifier, which will fail common markdown linting rules.
Suggested fix
Verify each finding against the current code and only fix it if needed.
In @.agents/skills/guidelines/SKILL.md around lines 59 - 63, The fenced code
block that currently starts with
(the three-backtick block showing the numbered verification steps) lacks a language tag and triggers markdownlint MD040; fix it by adding a language identifier (e.g., "text") immediately after the opening backticks so the block becomestext, ensuring the code fence istagged without changing the block contents.