Propagate timeout to _retrieve_offsets #33
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmichel-aiven
force-pushed
the
kmichel-timeout-on-offsets
branch
from
3a9434b to
a582aeb
Compare
The default timeout of _retrieve_offsets is infinite, this makes the Consumer block indefinitely even if poll was called with a timeout. Propagate the timeout from the Consumer to the Fetcher operation, removing some of the timeout as more and more sub-operation consume the total allowed timeout. During a `poll` operation, the timeout for positions and offsets is kept separate because poll will always keep running and accumulate messages until the end of the timeout. We want to be able to poll messages for a short time (or for zero time, the default) while allowing some delay when retrieving the positions.
kmichel-aiven
force-pushed
the
kmichel-timeout-on-offsets
branch
from
a582aeb to
d8dbea2
Compare
The default timeout of ensure_coordinator_ready is infinite, this makes the Consumer block indefinitely even if poll was called with a timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default timeout of
_retrieve_offsetsis infinite, this makes theConsumer block indefinitely even if poll was called with a timeout.
Propagate the timeout from the Consumer to the Fetcher operation,
removing some of the timeout as more and more sub-operation
consume the total allowed timeout.
During a
polloperation, the timeout for positions and offsets iskept separate because poll will always keep running and accumulate
messages until the end of the timeout. We want to be able to poll
messages for a short time (or for zero time, the default) while allowing
some delay when retrieving the positions.
Once
_retrieve_offsetsis fixed, the same problem happens withensure_coordinator_ready, this is fixed by the second commit.