Inkless Writer metrics in metrics.rst #347
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Gradle task :storage:inkless:genInklessMetricsDoc that generates the file docs/inkless/metrics.rst documenting Inkless-specific metrics. The task executes aiven.inkless.doc.MetricsDocs. At this point only AWS S3 storage backend metrics, Azure storage backend metrics and Google Cloud Storage backend metrics are included.
juha-aiven
force-pushed
the
metrics-documentation-storage-backends
branch
from
062556f to
d43b853
Compare
In order to expose the metrics, refactor WriterMetrics. For each metric introduce a corresponding MetricName. Add the description constants for all metrics. Finally, expose the metrics as MetricNameTemplate.
juha-aiven
force-pushed
the
metrics-documentation-inkless-writer-and-reader
branch
from
eabde76 to
f0d30e7
Compare
|
This PR is being marked as stale since it has not had any activity in 90 days. If you If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact). If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to expose the metrics, refactor WriterMetrics. For each metric introduce a corresponding MetricName. Add the description constants for all metrics. Finally, expose the metrics as MetricNameTemplate.