Skip to content

Fix/4447 upgrade grafana helm chart#4454

Open
souben wants to merge 6 commits intoagones-dev:mainfrom
souben:fix/4447-upgrade-grafana-helm-chart
Open

Fix/4447 upgrade grafana helm chart#4454
souben wants to merge 6 commits intoagones-dev:mainfrom
souben:fix/4447-upgrade-grafana-helm-chart

Conversation

@souben
Copy link
Copy Markdown

@souben souben commented Feb 23, 2026

What type of PR is this?

/kind cleanup

What this PR does / Why we need it

The Grafana Helm chart currently used by the project has been deprecated.
The chart was migrated to grafana-community/helm-charts effective January 30, 2026.
Running make minikube-setup-grafana produces a deprecation warning, and this PR is to migrate the project from grafana/grafana to grafana-community/grafana.

Note that a previous PR (#4449) addressing the issue was submitted previously, but it was stalled for around a week due to licencing issue, so this PR was submitted as a backup.

Changes

1. build/Makefile

Updated the setup-grafana target:
Old:

helm repo add grafana https://grafana.github.io/helm-charts
helm upgrade grafana grafana/grafana ...

New:

helm repo add grafana-community https://grafana-community.github.io/helm-charts
helm upgrade grafana grafana-community/grafana ...

The uninstall-grafana target remains unchanged since it references the release name.

2. build/grafana.yaml and build/grafana-frontend.yaml

Reviewed for compatibility with the new chart.
Current values work with the upgraded chart. Verified by installing the new chart and confirming dashboards load correctly.

3. Documentation

Updated site/content/en/docs/Guides/metrics.md:

  • Replaced the old repository URL with https://grafana-community.github.io/helm-charts
  • Updated helm repo add and helm upgrade commands to use grafana-community

Updated the build/docs/make-reference.md to reference the new Grafana Helm chart.

Which issue(s) this PR fixes

Closes #4447

@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/S labels Feb 23, 2026
Copy link
Copy Markdown
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the make reference please!

build/docs/make-reference.md

@souben
Copy link
Copy Markdown
Author

souben commented Feb 25, 2026

Sure @markmandel. I missed that one.
All is set now.

@markmandel
Copy link
Copy Markdown
Collaborator

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: e9e8d3e7-c99b-415f-a907-3e439c0e47b6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4454/head:pr_4454 && git checkout pr_4454
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.57.0-dev-cb7315a

Copy link
Copy Markdown
Contributor

@mikeseese mikeseese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs this one missed update; I can't see any more references other than in vendor/k8s.io/apimachinery/pkg/util/managedfields/node.yaml which I believe is negligible.

@markmandel
Copy link
Copy Markdown
Collaborator

@souben apologies for the delay on this one! Totally slipped through the cracks with GDC and the move to CNCF.

Can you please sign your commit - since we're now on a DCO system (see the action for details) rather than a CLA.

Just taking this for a spin now locally to make sure it all installs appropriately.

@markmandel
Copy link
Copy Markdown
Collaborator

Just needs this one missed update; I can't see any more references other than in vendor/k8s.io/apimachinery/pkg/util/managedfields/node.yaml which I believe is negligible.

@mikeseese I'm not sure I'm following this comment - do we need to upgrade a dependency for some reason?

Copy link
Copy Markdown
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took this for a run! Looks good!

Just need a signing on the git commit please.

@markmandel
Copy link
Copy Markdown
Collaborator

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 0cb0dcb3-81cc-4ed0-bbf3-dbd7dfdfefe5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4454/head:pr_4454 && git checkout pr_4454
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.57.0-dev-c491faf

@mikeseese
Copy link
Copy Markdown
Contributor

Just needs this one missed update; I can't see any more references other than in vendor/k8s.io/apimachinery/pkg/util/managedfields/node.yaml which I believe is negligible.

I'm not sure I'm following this comment - do we need to upgrade a dependency for some reason?

@markmandel I was referencing the collapsed suggested change in my review, which as been resolved:

image

I believe the vendor/k8s.io/apimachinery/pkg/util/managedfields/node.yaml is likely irrelevant, but my go experience is lacking here. Essentially, k8s.io is ultimately referring grafana/grafana in a K8s manifest that I'm guessing is completely unused by agones.

@markmandel
Copy link
Copy Markdown
Collaborator

markmandel commented Mar 25, 2026

Yeah that's just a vendored dependency - it has no impact on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Refactoring code, fixing up documentation, etc size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade deprecated Grafana Helm chart to grafana-community/grafana

4 participants