-
Notifications
You must be signed in to change notification settings - Fork 111
feat(unstable): Draft implementation of $/cancel_request notification
#303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbrandt
commented
Dec 5, 2025
3217a5d to
bff7f69
Compare
nerzhulart
reviewed
Dec 8, 2025
request/cancel notification$/cancel_request notification
7e33c0e to
f2b4e62
Compare
Aligns with JSON-RPC convention of using $/ prefix for protocol-level methods, following the same pattern as Language Server Protocol.
The cancel_request notification is a protocol-level feature that both sides must implement, not a capability to be negotiated. Move it from agent/client capabilities to a new protocol_level module and update schema generation accordingly. Also enable --all-features flag for clippy in CI to catch issues in feature-gated code.
f140493 to
398fad7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic schema primitives and documentation for the cancel request notification.