Llmo 3555 readability exclusions#2396
Open
noruiz wants to merge 11 commits intocode-freeze-apr-2026from
Open
Conversation
Please ensure your pull request adheres to the following guidelines: - [ ] make sure to link the related issues in this description - [ ] when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes - [ ] If data sources for any opportunity has been updated/added, please update the [wiki](https://wiki.corp.adobe.com/display/AEMSites/Data+Sources+for+Opportunities) for same opportunity. ## Related Issues Thanks for contributing! --------- Co-authored-by: Rares Cheseli <rcheseli@adobe.com>
# [1.416.0](v1.415.3...v1.416.0) (2026-04-16) ### Features * Add source in URL when fetching brand presence files ([#2394](#2394)) ([30ac0e4](30ac0e4))
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| */ | ||
| const CITATION_EXCLUSION_PATTERNS = [ | ||
| /doi:\s*10\.\d{4,}/i, | ||
| /\d{4};\s*(doi:|https?:\/\/)/i, |
Contributor
There was a problem hiding this comment.
Matches year; URL anywhere in text. A sentence like:
"The platform launched in 2022; https://results.example.com/ published the first results."
would be incorrectly excluded. The negative test on line 575 only validates year; text without a URL following. The risky pattern is year; https:// in normal prose — untested and unguarded.
| // include a citation tail (e.g. DOI) that would wrongly drop the whole element. | ||
| if ($el.html().includes('<br')) { | ||
| return true; | ||
| } |
Contributor
There was a problem hiding this comment.
Same situation for the
-split paragraph filter ( handler.js ). If a new exclusion signal is added in future, both sites need updating. Extract to a shared helper:
|
This PR will trigger a minor release when merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
Related Issues
https://jira.corp.adobe.com/browse/LLMO-3555
Thanks for contributing!