Skip to content

fix: ensure Virtualized Table loader width is up to date with table width#9961

Merged
LFDanLu merged 3 commits intomainfrom
9944
Apr 22, 2026
Merged

fix: ensure Virtualized Table loader width is up to date with table width#9961
LFDanLu merged 3 commits intomainfrom
9944

Conversation

@LFDanLu
Copy link
Copy Markdown
Member

@LFDanLu LFDanLu commented Apr 22, 2026

Closes #9944

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Go to the new RAC "virtualized table, loader dynamic width" story and ensure that resizing the table causes the loader to resize (aka the spinner should stay centered)

🧢 Your Project:

RSP

@github-actions github-actions Bot added the RAC label Apr 22, 2026
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yet another test story, but I couldn't reproduce the original issue via a test

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 22, 2026

Copy link
Copy Markdown
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LFDanLu LFDanLu added this pull request to the merge queue Apr 22, 2026
Merged via the queue into main with commit dae986e Apr 22, 2026
29 checks passed
@LFDanLu LFDanLu deleted the 9944 branch April 22, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table viewport virtual scroll does not update TableLoadMoreItem width on window resize

4 participants