Skip to content

fix: prevent form submission when required Select has more than 300 options and no selection #8280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lucasweng
Copy link
Contributor

Closes #8034

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  • Added a "Required Select With Many Items" story to RAC storybook to manually verify the behavior, since required select validation cannot currently be tested in the jsdom environment (see: http://github.com/jsdom/jsdom/issues/2898).

🧢 Your Project:

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be working as intended. I tried looking into a unit test for it working around the issue in the comment, but I don't think it's worth the effort in jsdom. Instead, we can write a play function to do it in storybook in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-aria-components Select required validation does not fire with more than 300 options
2 participants