Skip to content

Expose focus events' types on MenuItem #8231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

damianstasik
Copy link

Partially adresses #7453

Since MenuItem already passes onFocus, onBlur, and onFocusChange props directly to the useFocus hook, it would be great to explicitly expose the corresponding event types on MenuItem’s props interface.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Try it out in the Menu's story.

🧢 Your Project:

None

@snowystinger
Copy link
Member

Thanks for the PR, would you be willing to add some tests? https://react-spectrum.adobe.com/contribute.html#pull-requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants