Skip to content

TryOpen API #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AlexeiScherbakov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

TryOpen API #435

AlexeiScherbakov wants to merge 1 commit into from

Conversation

@AlexeiScherbakov
Copy link

@AlexeiScherbakov AlexeiScherbakov commented Jan 2, 2019

@adamhathcock adamhathcock self-requested a review January 3, 2019 14:27
adamhathcock
adamhathcock requested changes Jan 3, 2019
View reviewed changes
Copy link
Owner

@adamhathcock adamhathcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should change to make the mask an optional parameter (well, overload) and make the old code use the new Try path and throw an exception when false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamhathcock adamhathcock adamhathcock requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexeiScherbakov @adamhathcock