Skip to content

Enable -Werror=old-style-definition against more ports #10377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025

Conversation

jepler
Copy link

@jepler jepler commented May 27, 2025

[some of these I can't build at all on my travel laptop so I'll be using CI as a crutch a bit more than usual]

@jepler
Copy link
Author

jepler commented May 27, 2025

I'm surprised that this one affected just one board

../../shared-module/usb_cdc/__init__.c:359:8: error: old-style function definition [-Werror=old-style-definition]
  359 | size_t vendor_ms_os_20_descriptor_length() {

it seems to be a function that may only be built when CIRCUITPY_USB_VENDOR is enabled, which has something to do with webserial. but isn't webserial enabled across multiple boards? Is this a vestige?

Copy link
Collaborator

@eightycc eightycc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finish. Thank you!

@eightycc eightycc merged commit 116b29b into adafruit:main May 27, 2025
523 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants