Skip to content

Conversation

@JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Dec 11, 2025

PR Type

PR_TYPE

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

The crate has been archived and we have to migrate to rustls-pki-types: rustls/pemfile#61
This resolves the cargo-deny error.
We use it only on dev-deps so there's no effect on users.

@JohnTitor JohnTitor added B-semver-norelease change that does not require a release A-awc project: awc A-http project: actix-http A-web project: actix-web labels Dec 11, 2025
@JohnTitor JohnTitor marked this pull request as ready for review December 11, 2025 23:11
Copilot AI review requested due to automatic review settings December 11, 2025 23:11
@JohnTitor JohnTitor merged commit 41f99b0 into actix:main Dec 11, 2025
15 checks passed
@JohnTitor JohnTitor deleted the rpl-rustls-pemfile branch December 11, 2025 23:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces the archived rustls-pemfile crate with direct usage of rustls-pki-types types in response to the deprecation notice at rustls/pemfile#61. The migration simplifies TLS configuration setup in tests and examples by using rcgen's DER output directly instead of converting to PEM and parsing back.

  • Replaces rustls-pemfile dependency with rustls-pki-types version 1.13.1 in dev-dependencies
  • Simplifies certificate/key handling by using DER format directly from rcgen
  • Removes unnecessary PEM parsing and BufReader usage

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
awc/Cargo.toml Replaces rustls-pemfile with rustls-pki-types in dev-dependencies
awc/tests/test_rustls_client.rs Updates TLS config to use DER format directly, removes PEM parsing code
actix-web/Cargo.toml Replaces rustls-pemfile with rustls-pki-types in dev-dependencies
actix-web/tests/test_server.rs Updates TLS config in rustls module to use DER format directly
actix-http/Cargo.toml Replaces rustls-pemfile with rustls-pki-types in dev-dependencies
actix-http/tests/test_rustls.rs Updates TLS config to use DER format directly, removes BufReader import
actix-http/examples/ws.rs Updates TLS config example to use DER format with fully qualified types
actix-http/examples/tls_rustls.rs Updates TLS config example to use DER format with fully qualified types
Cargo.lock Removes rustls-pemfile entry, updates rustls-pki-types to 1.13.1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-awc project: awc A-http project: actix-http A-web project: actix-web B-semver-norelease change that does not require a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant