Interaction - Simplify pulling out bodies

[johnb432]

When merged this pull request will:

• Title.
• This means that the player will no longer enter the vehicle, which some might consider less realistic. Thoughts?

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[jonpas]

Reliability?

[johnb432]

Reliability?

Given that the medical interaction uses it for dead units, I imagine it's fine (testing supports that).

[Dystopian]

some might consider less realistic

Only some?
What problem does this PR solve?

[johnb432]

Only some?

Personally I don't care and as I don't want to speak for everyone, I used "some".

What problem does this PR solve?

It simplifies the function and make it more in line with the medical action's behaviour. The medical unload patient action uses moveOut for dead units, so I figured why not here too.

[Dystopian]

I think medical magic action should be more realistic then.

[johnb432]

I think medical magic action should be more realistic then.

Personally, I'm against that, as I find it cumbersome.

Unifying the behaviour should the way forward, I imagine we can agree on that. I'd like to test if using moveOut or the more realistic method is better when it comes to avoiding ragroll carnage (which was the earliest intent of the PR) before making any changes.

[Dystopian]

Ragdoll carnage is still here when you just get in vehicle at dead body seat.

[rautamiekka]

Unless you're pulling someone outta a vehicle turret or from a rear-loaded vehicle such as a troop truck or an APC, you most likely ain't going inside the vehicle anyway, so in that sense this is more realistic.

Personally don't really care if you go inside and back outside as part of the animation, but if it simplifies the code or improves performance or makes armaing less likely, then I'm all for it.

[LinkIsGrim]

Ragdoll carnage is still here when you just get in vehicle at dead body seat.

You shouldn't be able to do that, seat should be locked when unit goes uncon/is killed. Can you repro?

[LinkIsGrim]

Also, a good middle ground for realism would be carrying the body when pulling it out, but we've seen how that went.

Personally I'm for this, the get in/out loop to pull out a body was more annoying than anything to me, especially when the vehicle is local to a laggy machine.

[Andx667]

whats the status on this?

[LinkIsGrim]

Now that carrying dead bodies is stable we can probably add a check for dragging loaded and use that after moveOut.

Otherwise, my opinion is the same.

[Dystopian]

You shouldn't be able to do that, seat should be locked when unit goes uncon/is killed. Can you repro?

@LinkIsGrim I never played with ACE Medical and didn't know it locks seats when a unit is dead or unconscious. I discovered this while testing #11372. So the repro is simply to disable Medical :) Sorry for the late reply.

I've just tested unloading bodies from a truck with moveOut. It's really too fast without animations. You can unload an entire truck in just a few seconds. So I'd prefer to keep the animation, at least as an optional feature.

As for carrying after pulling out, that could also be too fast (since the default carry-start animation would look awkward for a unit that was just moved out). It could also require additional logic for situations where carrying is not possible (e.g. due to injured legs).

@johnb432 after all this time, I don't really mind if you remove this feature. I can implement it myself and use it in my games. All I'd ask is to remove the function and simply replace the statement with moveOut _target.

[Dystopian]

Can make it optional with variable:

Suggested change

	if (GETMVAR(GVAR(simplePullOut),true)) exitWith {moveOut _body};

Name and default value as you wish.

[johnb432]

I've just tested unloading bodies from a truck with moveOut. It's really too fast without animations. You can unload an entire truck in just a few seconds. So I'd prefer to keep the animation, at least as an optional feature.

We could add a progress bar to slow it down.