feat: notify platform admins on user creation and deletion (resolves #3040) by rvs1212 · Pull Request #3042 · accessibility-exchange/platform

rvs1212 · 2026-03-18T22:34:33Z

Added notification feature for platform admins when:

A new individual or training participant registers
A new organization or regulated organization is created
A member accepts an invitation to join an organization
A user deletes their account

Platform admins receive both email and dashboard notifications.

Resolves #3040

Prerequisites

If this PR changes PHP code or dependencies:

I've run composer format and fixed any code formatting issues.
I've run composer analyze and addressed any static analysis issues.
I've run php artisan test and ensured that all tests pass.
I've run composer localize to update localization source files and committed any changes.

If this PR changes CSS or JavaScript code or dependencies:

I've run npm run lint and fixed any linting issues.
I've run npm run build and ensured that CSS and JavaScript assets can be compiled.

codecov · 2026-03-18T22:53:49Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.04%. Comparing base (bf76f37) to head (91045de).

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #3042      +/-   ##
============================================
+ Coverage     96.99%   97.04%   +0.04%     
- Complexity     2472     2505      +33     
============================================
  Files           379      389      +10     
  Lines         11287    11477     +190     
============================================
+ Hits          10948    11138     +190     
  Misses          339      339

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jobara · 2026-03-26T11:03:37Z

app/Observers/UserObserver.php

+                'name'
+            ))->decryptValue($user->name);
+
+            $admins = User::whereAdministrator()->where('id', '!=', $user->id)->get();


I don't think the extra where is needed as it appears that this is only run when the $user is not an administrator.

jobara · 2026-03-26T11:54:06Z

app/Observers/UserObserver.php

+                userName: $name,
+                userEmail: $email,
+                userContext: $user->context,


This will expose the users name and info outside of TAE's system. Is this information actually necessary?

Modified the email notification content considering privacy

jobara · 2026-03-26T13:19:37Z

app/Http/Controllers/InvitationController.php

+        if ($invitationable instanceof Organization || $invitationable instanceof RegulatedOrganization) {
+            $invitee = $this->retrieveUserByEmail($inviteeEmail);
+
+            if ($invitee) {


Is there a case where this is falsey? Depending on the case there may be something else that should be done.

There won't be a case where $invitee can be falsey. The request validation confirms the authenticated user's email matches the invitation email, so the user will exist. Removed that.

jobara · 2026-03-26T13:26:10Z

app/Notifications/NewMemberJoinedOrganization.php

+
+    private function contextLabel(): string
+    {
+        return UserContext::labels()[$this->userContext] ?? $this->userContext;


Realistically there shouldn't be a case where the contextLabel doesn't return a value. I wonder if you want to return something like __('Unknown') or leave as null in this case and log an error.

jobara · 2026-03-26T13:57:51Z

app/Notifications/NewMemberJoinedOrganization.php

+            'title' => __('New member joined organization'),
+            'body' => __(':name has joined :organization as :role.', [
+                'name' => $this->memberName,
+                'organization' => $this->organization->getTranslation('name', locale()),
+                'role' => $this->memberRole,


This should follow a similar pattern as the other notifications. These strings are built up in the notification view component instead. This should just pass along the necessary parts needed by the view. Apart from consistency, I believe this will also mean that localization happens at the time the notification view is rendered, instead of when the notification is generated.

Oke. Modified the approach.

jobara · 2026-03-26T13:59:05Z

app/Notifications/NewMemberJoinedOrganization.php

+        public string $memberRole,
+        public string $userContext,


It's likely you'll need to pass in the actually object instance instead of the string, so that you can pass it along to the notification view. This way it can do the localization at render time.

sure, modified the approach

jobara · 2026-03-26T15:11:18Z

resources/views/mail/new-member-joined-organization.blade.php

+<p>
+@lang('mail.salutation'),<br>
+{{ config('app.name') }}
+</p>


I think this may already be included in another template.

platform/resources/views/vendor/notifications/email.blade.php

Lines 42 to 48 in bf76f37

{{-- Salutation --}}

@if (! empty($salutation))

{{ $salutation }}

@else

@lang('mail.salutation'),<br>

{{ config('app.name') }}

@endif

jobara

I think it would be be helpful

jobara · 2026-04-01T18:58:43Z

app/View/Components/Notification/NewUserRegistered.php

+        $this->body = __('A new user, :name, has registered as :context.', [
+            'name' => $notification->data['user_name'],
+            'context' => UserContext::labels()[$notification->data['user_context']],
+        ]);


I don't think this is actually enough information, for example multiple users could have the same name. Also if you just pass along the email address, the user could change that at any time, so it also may not match. This can be probably be mostly mitigated by passing along the User and displaying the email as it is at render time. In an ideal world, you'd provide a link directly to the user, but there isn't a page for that yet, and is something more along the lines of #1802.

Could also make the user name a link to their public page if one has been created/drafted.

NOTE: this isn't intended as a comment to address the previous comment above.

jobara · 2026-04-01T19:05:25Z

app/Observers/UserObserver.php

+            Notification::send($admins, new NewUserRegistered(
+                userName: $name,
+                userContext: UserContext::from($user->context),
+            ));


I think this is actually too soon to send, as the user hasn't actually complete the registration process yet. It kind of depends on what you want to do with the information. On one hand it would be useful to know when a user is created, even if they aren't fully registered. However, if the point is to use that information to go into the manage accounts, the user may not show up yet.

You can replicate this by creating a new individual user, and monitoring the emails in mailpit. You'll get the email notification before the registration process completes. I think right after the password is created. If you look in manage accounts, the user won't be visible. They need to complete the other registration steps before they'll show up in the manage accounts screen.

jobara · 2026-04-02T12:20:43Z

app/Observers/OrganizationObserver.php

+
+class OrganizationObserver
+{
+    public function created(Organization $organization): void


This may be too soon, and/or there may be a bug in the manage accounts view. The issue is that the Org does appear in the manage accounts screen but it isn't searchable until after the org has drafted a public page.

The org "Org" is in the manage accounts list.

However, searching for "Org" says there are two results but doesn't render the one we're actually looking for.

After drafting a public page for the Org, it is now searchable.

jobara · 2026-04-02T12:39:09Z

app/Observers/RegulatedOrganizationObserver.php

+            Notification::send($admins, new NewOrganizationRegistered(
+                creatorName: $creator->name,
+                organization: $regulatedOrganization,
+                userContext: UserContext::from($creator->context),
+            ));


Same notification class is used for both the Organizations and Regulated Organizations. Due to this and the nature of its implementation, it's harder to distinguish the actual type of organization created. The context is included in the app notification but there the title is still just organization. Maybe check with Erick to see if this is sufficient, but you might want to actually title these as Organization and Regulated Organization. If you do make this change, you could either created separate notification classes or you could include logic to distinguish the type based on the UserContext.

jobara · 2026-04-02T12:43:51Z

resources/views/components/notification/new-user-registered.blade.php

+<x-notification :notification="$notification">
+    <x-slot name="title">{{ $title }}</x-slot>
+    <x-slot name="body">{{ $body }}</x-slot>
+</x-notification>


For user types that can be managed, it would be helpful to add an actions slot with a link to the Manage Accounts page. This also applies to organization notifications.

jobara · 2026-04-02T12:50:57Z

app/View/Components/Notification/NewMemberJoinedOrganization.php

+        $this->body = __(':name has joined :organization as :role.', [
+            'name' => $notification->data['member_name'],
+            'organization' => $organization->getTranslation('name', locale()),
+            'role' => TeamRole::labels()[$notification->data['team_role']],
+        ]);


The organization name should be a link to the organization's public page.

jobara · 2026-04-02T12:55:20Z

app/View/Components/Notification/UserAccountDeleted.php

+            $organizationType = $notification->data['organization_type'];
+            $organization = $organizationType::find($notification->data['organization_id']);
+
+            $this->body = __(':name (:context) from :organization has deleted their account.', [


I think in this case the context is actually referring to the organization and should be moved after the organization's name instead of the user's name.

Also may want to make the organization's name a link to the organizations public page.

jobara · 2026-04-02T13:03:09Z

app/Http/Controllers/InvitationController.php

+            Notification::send($admins, new NewMemberJoinedOrganization(
+                memberName: $invitee->name,
+                organization: $invitationable,
+                teamRole: TeamRole::from($role),
+            ));


The NewMemeberJoinedOrganization is used for both organizations and regulated organizations but doesn't distinguish between them in the notification. As mentioned in another comment for new orgs, you should consider making this distinction to keep things clear on the system. Could either be separate classes or logic in the same class that distinguishes the two.

jobara · 2026-04-02T13:08:52Z

app/View/Components/Notification/UserAccountDeleted.php

+                'organization' => $organization->getTranslation('name', locale()),
+            ]);
+        } else {
+            $this->body = __(':name (:context) has deleted their account.', [


This is slightly confusing in the context of a user who was part of an organization but was removed from the organization before they deleted their account.

In this case this case the context is still "Community Organization" or "Regulated Organization". Probably best to check with Erick to see how he feels about this.

Steps to reproduce:

Create an org or fro

Invite a new user to it

Create the new user account and accept the invite

From the org/fro remove the new user

As the invited user, delete their account

jobara · 2026-04-02T13:28:22Z

app/View/Components/Notification/NewUserRegistered.php

+    public function __construct(DatabaseNotification $notification)
+    {
+        $this->title = __('New user registered');
+        $this->body = __('A new user, :name, has registered as :context.', [


I think the grammar is a bit off and will likely need to be toggled based on the context.

For example:

'A new user, :name, has registered as a :context.' (e.g. Training Participant)

'A new user, :name, has registered as an :context.' (e.g. Individual)

rvs1212 added 4 commits March 2, 2026 16:53

feat: notify platform admins when new users register

8822c08

feat: notify platform admins when a user deletes their account

db10835

fix: resolve notification translations in admin's preferred locale

f42783d

test: add tests for admin user notification feature

6c1b21b

rvs1212 requested a review from jobara March 18, 2026 22:37

test: add additional test cases for admin notification

fcdc049

jobara requested changes Mar 26, 2026

View reviewed changes

refactor: address PR review feedback for admin notifications

91045de

jobara requested changes Apr 2, 2026

View reviewed changes

	{{-- Salutation --}}
	@if (! empty($salutation))
	{{ $salutation }}
	@else
	@lang('mail.salutation'),<br>
	{{ config('app.name') }}
	@endif

Conversation

rvs1212 commented Mar 18, 2026

Prerequisites

Uh oh!

codecov bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jobara left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Mar 18, 2026 •

edited

Loading