Fix "_init_model" resseting params of Command Prompt #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(repair-wheel): make the repair-wheel logic optional absadiki#95
fix(print_progress): print progress callback absadiki#97
Fix issue with parameters resetting to default values when executing in the command prompt.
|
@absadiki The "whisper.cpp" folder won't let me squash commits. |
|
Okey. no worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#97 Not the main problem, but one caused by it. Fixed a problem, in these new commit (
version 1.3.1.dev13), that occurred when callingpwcppfrom the command line, where there was a line in the code (_init_model) which resets what was entered to certain default values (for example, I want to transcribe in Spanish, but it returns it to English with "[Spanish]" and "(speaking in foreign language)"). For this, different lines were added to the code to capture the logs provided by the program in the console (it captured the parameters, but restarted them). Finally, the problem was solved by deleting a line (actually commented), and I deleted the log captures that I placed to identify the problem. I tested the program in the command prompt and in a.pyfile with different parameters, and there were no errors.