Skip to content

fix: client should not specify taskId if it doesn't exist #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

njbrake
Copy link
Contributor

@njbrake njbrake commented Jul 1, 2025

Description

I'm submitting this PR as a proposal based off of #218 (comment).

If the taskId doesn't exist, I was thinking that an exception should be thrown to prevent the client from specifying the id. The reason I think this change is required because if the client specifies a taskId but one doesnt exist, it won't actually get push notifications based off that first request, because the logic to set_info() gets skipped because there is no task when _setup_message_execution is called.

Found while working on mozilla-ai/any-agent#414

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass (Run nox -s format from the repository root to format)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@njbrake njbrake requested a review from a team as a code owner July 1, 2025 17:38
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @njbrake, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the server's message processing logic by adding a crucial validation step for client-provided task IDs. The change ensures that any taskId sent by a client must refer to an existing task, thereby preventing incorrect state or missed notifications and providing immediate, actionable error feedback for invalid inputs.

Highlights

  • Input Validation: I've introduced explicit validation within the _setup_message_execution function to ensure that if a client provides a taskId in their message, it corresponds to an existing task. This prevents scenarios where a client might specify a non-existent ID, leading to skipped logic for push notifications.
  • Error Handling: If a taskId is specified by the client but no corresponding task is found, the system now raises a ServerError encapsulating an InvalidParamsError. This provides clear feedback to the client that the provided taskId is invalid, improving API robustness and preventing silent failures.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a check to ensure that a taskId exists before proceeding, throwing an error if it doesn't. This prevents silent failures and improves client feedback.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@holtskinner holtskinner changed the title fix: client should not specify taskId if it doesn't exist fix: client should not specify taskId if it doesn't exist Jul 1, 2025
Copy link
Member

@holtskinner holtskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @kthota-g @swapydapy Can you review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants