Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the project's cryptographic hashing operations to the @noble/hashes library, replacing several legacy dependencies including fast-sha256, hash.js, js-sha256, create-hash, object-hash, and sha.js. The changes standardize hashing implementations across backends, stores, and components, and include necessary updates to the dependency configuration and Jest mapping. I have no feedback to provide.
|
Looks good, can you please check out this as well? |
|
we should keep it async ( |
9211df2 to
ec6b7cb
Compare
|
maybe we should break out hashing functionality out into a Hash/HashingUtils file. We could then add appropriate tests for the existing implementations, then potentially have some assurance that outputs don't change when switching to the new library. |
Description
Relates to issue: ZEUS-3989
This pull request is categorized as a:
Checklist
yarn run tscand made sure my code compiles correctlyyarn run lintand made sure my code didn’t contain any problematic patternsyarn run prettierand made sure my code is formatted correctlyyarn run testand made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
On-device
Remote
Locales
Third Party Dependencies and Packages
yarnafter this PR is merged inpackage.jsonandyarn.lockhave been properly updatedOther: