refactor: improve UTXOPicker sheet UX#3949
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the UTXOPicker component by replacing the standard Modal with a ModalBox styled as a bottom sheet and improving state management for UTXO selection. Key changes include adding a draft state for modal selections, implementing mount checks for asynchronous label loading, and enhancing type safety. The review feedback suggests performance optimizations such as parallelizing label fetching with Promise.all and moving the renderItem function to a class method to prevent unnecessary re-renders, as well as simplifying the keyExtractor logic to avoid redundant fallback code.
a7b3e00 to
2ef1bc5
Compare
shubhamkmr04
left a comment
There was a problem hiding this comment.
Simulator.Screen.Recording.-.iPhone.17.Pro.Max.-.2026-04-17.at.15.22.43.mov
nit: we should have some top and bottom padding in this component + remove the vertical scroll bar
a5c4e18 to
49c8ed0
Compare
Description
Relates to issue: ZEUS-0000
Please enter a description and screenshots, if appropriate, of the work covered in this PR
This pull request is categorized as a:
Checklist
yarn run tscand made sure my code compiles correctlyyarn run lintand made sure my code didn’t contain any problematic patternsyarn run prettierand made sure my code is formatted correctlyyarn run testand made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
On-device
Remote
Locales
Third Party Dependencies and Packages
yarnafter this PR is merged inpackage.jsonandyarn.lockhave been properly updatedOther: